feat: make OnTime fully local-only - #580
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 1639400): https://on-time-front-widgetbook--pr-580-vvryaypl.web.app (expires Mon, 31 Aug 2026 17:59:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e53128a376fed0209d449279de9c0d94c83cdd8b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lifecycle and migration
This is an intentional one-way cutover. Existing remote credentials, caches, legacy local rows, device delivery records, and active sessions are discarded before onboarding. There is no server import path. Active local data is encrypted with a device-bound key. Backup restore authenticates and previews the portable backup before replacing active data atomically, then rebuilds delivery registrations.
Onboarding now preserves immutable preparation-step state while reordering, retains existing durations, and persists the exact spare time shown and edited in the UI. The settings surface uses a Material paint boundary so ListTile ink and backgrounds remain visible under Flutter 3.44.
Persistence and delivery safety
Validation
dart run build_runner build -d— passed; generated Dart policy alignedflutter analyze— no issuesflutter test --coverage --concurrency=1— 550 passeddart run tool/check_local_only_boundary.dart— passedflutter build web --release— passedflutter build web --release— passed with Flutter 3.44-compatible toolinggit diff --check— passedGenerated and platform files
Dependency changes update the tracked native plugin registrants and lockfiles. Generated Dart outputs remain ignored and are not committed. The iOS Podfile is checked in so archive builds can resolve the remaining local-only plugins.
Out of scope