Skip to content

feat: make OnTime fully local-only #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjoonleo merged 6 commits into from
Aug 28, 2026
Merged

feat: make OnTime fully local-only #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ccc6272
feat: make OnTime fully local-only
jjoonleo Aug 28, 2026
6fd1db3
test: cover local-only onboarding and settings
jjoonleo Aug 28, 2026
3085b71
fix: preserve local onboarding state
jjoonleo Aug 28, 2026
713da9b
test: align local settings fixtures
jjoonleo Aug 28, 2026
b8d2d32
fix: persist visible onboarding spare time
jjoonleo Aug 28, 2026
1639400
fix: align offline database tooling
jjoonleo Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
23 changes: 6 additions & 17 deletions .github/workflows/android-play-closed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,11 @@ jobs:
ANDROID_KEYSTORE_PASSWORD: ${{ secrets.ANDROID_KEYSTORE_PASSWORD }}
ANDROID_KEY_ALIAS: ${{ secrets.ANDROID_KEY_ALIAS }}
ANDROID_KEY_PASSWORD: ${{ secrets.ANDROID_KEY_PASSWORD }}
REST_API_URL: ${{ vars.REST_API_URL }}

steps:
- name: Validate workflow inputs
env:
ANDROID_VERSION_CODE: ${{ inputs.android_version_code }}
ANDROID_GOOGLE_SERVICES_JSON_B64: ${{ secrets.ANDROID_GOOGLE_SERVICES_JSON_B64 }}
ANDROID_UPLOAD_KEYSTORE_B64: ${{ secrets.ANDROID_UPLOAD_KEYSTORE_B64 }}
GOOGLE_PLAY_SERVICE_ACCOUNT_JSON: ${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }}
run: |
Expand All @@ -50,13 +48,11 @@ jobs:

missing=0
for name in \
ANDROID_GOOGLE_SERVICES_JSON_B64 \
ANDROID_UPLOAD_KEYSTORE_B64 \
ANDROID_KEYSTORE_PASSWORD \
ANDROID_KEY_ALIAS \
ANDROID_KEY_PASSWORD \
GOOGLE_PLAY_SERVICE_ACCOUNT_JSON \
REST_API_URL
GOOGLE_PLAY_SERVICE_ACCOUNT_JSON
do
if [ -z "${!name}" ]; then
echo "$name is required for Android Play closed testing deploy." >&2
Expand All @@ -82,15 +78,7 @@ jobs:
run: echo "ANDROID_KEYSTORE_PATH=$RUNNER_TEMP/ontime-upload.jks" >> "$GITHUB_ENV"

- name: Install native test dependencies
run: sudo apt-get update && sudo apt-get install -y sqlite3 libsqlite3-dev

- name: Decode Android Firebase config
env:
ANDROID_GOOGLE_SERVICES_JSON_B64: ${{ secrets.ANDROID_GOOGLE_SERVICES_JSON_B64 }}
run: |
mkdir -p android/app/src/release
printf '%s' "$ANDROID_GOOGLE_SERVICES_JSON_B64" | base64 --decode > android/app/src/release/google-services.json
test -s android/app/src/release/google-services.json
run: sudo apt-get update && sudo apt-get install -y sqlite3 libsqlite3-dev libsodium-dev

- name: Decode Android upload keystore
env:
Expand All @@ -109,6 +97,9 @@ jobs:
- name: Check generated Dart policy
run: dart run tool/check_generated_dart_policy.dart

- name: Check local-only product boundary
run: dart run tool/check_local_only_boundary.dart

- name: Verify generation left tracked files unchanged
run: git diff --exit-code

Expand All @@ -132,9 +123,7 @@ jobs:
run: |
flutter build appbundle --release \
--build-name="$ANDROID_BUILD_NAME" \
--build-number="${{ inputs.android_version_code }}" \
--dart-define=ENV=staging \
--dart-define=REST_API_URL="$REST_API_URL"
--build-number="${{ inputs.android_version_code }}"

- name: Prepare Play release notes
if: ${{ inputs.release_notes != '' }}
Expand Down
23 changes: 6 additions & 17 deletions .github/workflows/android-play-internal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,11 @@ jobs:
ANDROID_KEYSTORE_PASSWORD: ${{ secrets.ANDROID_KEYSTORE_PASSWORD }}
ANDROID_KEY_ALIAS: ${{ secrets.ANDROID_KEY_ALIAS }}
ANDROID_KEY_PASSWORD: ${{ secrets.ANDROID_KEY_PASSWORD }}
REST_API_URL: ${{ vars.REST_API_URL }}

steps:
- name: Validate workflow inputs
env:
ANDROID_VERSION_CODE: ${{ inputs.android_version_code }}
ANDROID_GOOGLE_SERVICES_JSON_B64: ${{ secrets.ANDROID_GOOGLE_SERVICES_JSON_B64 }}
ANDROID_UPLOAD_KEYSTORE_B64: ${{ secrets.ANDROID_UPLOAD_KEYSTORE_B64 }}
GOOGLE_PLAY_SERVICE_ACCOUNT_JSON: ${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }}
run: |
Expand All @@ -46,13 +44,11 @@ jobs:

missing=0
for name in \
ANDROID_GOOGLE_SERVICES_JSON_B64 \
ANDROID_UPLOAD_KEYSTORE_B64 \
ANDROID_KEYSTORE_PASSWORD \
ANDROID_KEY_ALIAS \
ANDROID_KEY_PASSWORD \
GOOGLE_PLAY_SERVICE_ACCOUNT_JSON \
REST_API_URL
GOOGLE_PLAY_SERVICE_ACCOUNT_JSON
do
if [ -z "${!name}" ]; then
echo "$name is required for Android Play internal deploy." >&2
Expand All @@ -78,15 +74,7 @@ jobs:
run: echo "ANDROID_KEYSTORE_PATH=$RUNNER_TEMP/ontime-upload.jks" >> "$GITHUB_ENV"

- name: Install native test dependencies
run: sudo apt-get update && sudo apt-get install -y sqlite3 libsqlite3-dev

- name: Decode Android Firebase config
env:
ANDROID_GOOGLE_SERVICES_JSON_B64: ${{ secrets.ANDROID_GOOGLE_SERVICES_JSON_B64 }}
run: |
mkdir -p android/app/src/release
printf '%s' "$ANDROID_GOOGLE_SERVICES_JSON_B64" | base64 --decode > android/app/src/release/google-services.json
test -s android/app/src/release/google-services.json
run: sudo apt-get update && sudo apt-get install -y sqlite3 libsqlite3-dev libsodium-dev

- name: Decode Android upload keystore
env:
Expand All @@ -105,6 +93,9 @@ jobs:
- name: Check generated Dart policy
run: dart run tool/check_generated_dart_policy.dart

- name: Check local-only product boundary
run: dart run tool/check_local_only_boundary.dart

- name: Verify generation left tracked files unchanged
run: git diff --exit-code

Expand All @@ -128,9 +119,7 @@ jobs:
run: |
flutter build appbundle --release \
--build-name="$ANDROID_BUILD_NAME" \
--build-number="${{ inputs.android_version_code }}" \
--dart-define=ENV=staging \
--dart-define=REST_API_URL="$REST_API_URL"
--build-number="${{ inputs.android_version_code }}"

- name: Prepare Play release notes
if: ${{ inputs.release_notes != '' }}
Expand Down
54 changes: 0 additions & 54 deletions .github/workflows/firebase-hosting-merge.yml
View file
Open in desktop

This file was deleted.

57 changes: 0 additions & 57 deletions .github/workflows/firebase-hosting-pull-request.yml
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions .github/workflows/flutter_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
flutter-version: "3.44.4"
channel: stable
cache: true
- name: install sql
run: sudo apt-get install sqlite3 libsqlite3-dev
- name: install native test dependencies
run: sudo apt-get install sqlite3 libsqlite3-dev libsodium-dev
- name: Install packages
run: flutter pub get
- name: Check Flutter version
Expand All @@ -31,6 +31,8 @@ jobs:
run: dart run build_runner build --delete-conflicting-outputs
- name: Check generated Dart policy
run: dart run tool/check_generated_dart_policy.dart
- name: Check local-only product boundary
run: dart run tool/check_local_only_boundary.dart
- name: Analyze
run: flutter analyze
- name: Run test with coverage
Expand Down
Loading
Loading