Repository navigation
chore: update organization references from typefield to DingTalk-Real-AI - #1
Conversation
There was a problem hiding this comment.
请求修改:文档中的 Maven 坐标和 Java 包名已改为 io.github.dingtalk-real-ai(例如 README.md:13,72,101)。当前 pom.xml:7 仍声明 io.github.typefield,源代码包也仍是 io.github.typefield...;而且 Java 包名不能包含连字符。因此 README 的依赖、import 和 exec.mainClass 示例都不可用。
请在本 PR 中恢复为当前已发布的坐标/包名,或另行完整迁移 POM、源码包路径、所有 import 和发布流程后再更新文档。
大段文档翻译建议拆分为独立 PR,避免掩盖组织引用迁移的功能性改动。
89a5ff9 to
dd3b224
Compare
|
✅ 已完整修复 Maven 坐标已完整迁移:
测试验证: 文档已同步: 请重新审核,感谢! |
haofeng0705
left a comment
There was a problem hiding this comment.
请求修改:README.md 第 72、101 行以及 SPEC.md 第 285 行把包名写成 com.dingtalk.dingtalk.channel,但实际源码声明为 com.dingtalk.channel。复制 README 的 import 或 LiveCheck 命令都会失败。请将所有文档示例统一为实际包名。另请在 PR 描述中明确 Maven groupId 与公共 Java package 的破坏性迁移及兼容/版本策略。
|
Thanks for the careful reviews. Both rounds are addressed per the decision to complete the full migration rather than revert: Review 1 (coordinates/packages vs POM):
Review 2 (doc examples wrong package + migration note):
Ready for re-review @haofeng0705. |
|
@haofeng0705 两轮评审意见已在后续提交全部解决,请求复查合并:
|
haofeng0705
left a comment
There was a problem hiding this comment.
复查结论:请求修改。
GUIDE.md:1、OVERVIEW.md:1、SPEC.md:1 仍链接到本 PR 已删除的 *.zh-CN.md,合并后会产生 3 个失效链接。包名、Maven 坐标和 imports 的迁移检查未发现旧包名残留,但本机缺少 JDK/Maven,且 PR 没有 CI checks,无法独立确认编译和 37 项测试结果。
请先修复断链,并补充可见的 CI/构建结果后再合入。
haofeng0705
left a comment
There was a problem hiding this comment.
复查结论:请求修改。
GUIDE.md:1、OVERVIEW.md:1、SPEC.md:1 仍然链接到 ./GUIDE.zh-CN.md、./OVERVIEW.zh-CN.md、./SPEC.zh-CN.md,但仓库中只存在 README.zh-CN.md,这三个文件不存在,合并后会产生 404。
请补齐缺失的 zh-CN 文档,或移除这三个失效链接。其余包名/Maven 迁移检查未发现旧包名残留,但本机无 JDK/Maven,依赖新增 CI 验证。
haofeng0705
left a comment
There was a problem hiding this comment.
复查:Java 8 兼容修复本身正确(以 ByteArrayOutputStream 循环读取替代 InputStream.readAllBytes,并将测试中的 List.of 替换为 Arrays.asList)。但该 fork 分支仍基于合入 #3 前的 main,与当前 main 存在冲突,无法合入且未生成新的 CI。请先 rebase 到当前 main、保留上述兼容修复并解决冲突;等待 Java 8/11/17 CI 全绿后再复查。
a699653 to
abbb367
Compare
|
@haofeng0705 已 rebase 到当前 main,并解决合并冲突。最新 Java CI 已通过 Java 8/11/17 矩阵:https://github.com/typefield/dingtalk-channel-sdk-java-1/actions/runs/35502112891 。请重新复查。 |
haofeng0705
left a comment
There was a problem hiding this comment.
复查通过:已 rebase 到当前 main,仅保留文档死链清理、Java 8 兼容读取与测试兼容三项改动;Java 8/11/17 CI 全绿,可合入。
…#2) * docs: fix Java Maven coordinates to com.dingtalk:dingtalk-channel-sdk The cross-language install table wrote the Java coordinates as io.github.DingTalk-Real-AI:dingtalk-channel-sdk, which is neither the current published artifact nor a resolvable groupId (groupIds cannot be an org slug). Align with the Java SDK migration to com.dingtalk:dingtalk-channel-sdk (DingTalk-Real-AI/dingtalk-channel-sdk-java#1), which updates the POM groupId and all source packages to com.dingtalk.channel. * docs: clarify Java Maven coordinate status as pending release Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: typefield <typefield@users.noreply.github.com> Co-authored-by: 玉澜 <yulan.wqy@alibaba-inc.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Update all references from typefield to DingTalk-Real-AI organization and migrate the published coordinates:
Breaking changes (migration complete in this PR)
io.github.typefieldcom.dingtalkio.github.typefield.dingtalk.channelcom.dingtalk.channel<groupId>com.dingtalk</groupId><artifactId>dingtalk-channel-sdk</artifactId><version>0.1.0</version>import com.dingtalk.channel.DingTalkChannel;0.1.0release from this repository; noio.github.typefieldcompatibility shim is provided.com.dingtalk.channel.*; verified withmvn compileandmvn test.com.dingtalk.dingtalk.channeltypos in README/README.zh-CN/SPEC).