Repository navigation
Fix report persistence, search API, Playwright CI and open redirect - #1688
Merged
yusuftomilola merged 7 commits intoOct 17, 2026
Merged
yusuftomilola merged 7 commits into
yusuftomilola merged 7 commits into
Conversation
|
@Nimatstar Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Nimatstar is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four frontend issues with small, focused changes:
#1617 - Report builder saved reports persistence
frontend/lib/api/saved-reports.tswith a typed API client for thesaved-reportsresource (list, create, rename, delete, duplicate).reports/builder/page.tsxto load saved reports from the API on mount and persist new reports through the API (with a local fallback if the backend is not yet available).#1607 - Global search bypasses API client and auth
frontend/lib/api/search.tsusing the shared axios instance (correct base URL + auth token).search/page.tsxto callsearchApiClient.search()instead of rawfetch('/api/search'), including an abort signal for cancellation.#1606 - Playwright e2e suite not run in CI
e2ejob tofrontend-ci.ymlthat installs browsers (npx playwright install --with-deps chromium), builds the app, runsnpm run test:e2e, and uploads HTML report + traces on failure.NEXT_PUBLIC_API_URLto use port 6003 (the backend default).#1604 - Open redirect via unvalidated
redirectquery paramfrontend/lib/utils/redirect-validation.tswithgetSafeRedirect()that rejects absolute, protocol-relative, backslash, and encoded-scheme variants, falling back to/dashboard.login/page.tsxto usegetSafeRedirect()instead of passing the raw query param torouter.push().Closes #1617
Closes #1607
Closes #1606
Closes #1604