Repository navigation
Fix freighter-api dependency, duplicate Dashboard dirs, scan page and CI type-check - #1690
Merged
yusuftomilola merged 8 commits intoOct 17, 2026
Conversation
|
@zakariyaufarida5-wq is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@zakariyaufarida5-wq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four frontend issues with small, focused changes:
#1622 - @stellar/freighter-api is not a dependency
@stellar/freighter-apitopackage.jsondependencies so the dynamic import inwallet.store.tsresolves on a clean install.#1618 - Four duplicate Dashboard component directories
DashboardCharts.tsxandDateRangeSelector.tsxfromcomponents/Dashboard/andstore/Dashboard/.features/Dashboard/remains the single source of truth with its spec files.#1608 - Public scan page fetches a relative URL
app/scan/[assetId]/page.tsxto use the API base URL (NEXT_PUBLIC_API_URL) via axios instead of a relativefetch('/api/...').#1605 - CI runs non-existent ype-check script and never runs tests
"type-check": "tsc --noEmit"script topackage.json.npm run test(Jest) step tofrontend-ci.yml.NEXT_PUBLIC_API_URLto use port 6003 (the backend default).Closes #1622
Closes #1618
Closes #1608
Closes #1605