Skip to content

Fix freighter-api dependency, duplicate Dashboard dirs, scan page and CI type-check - #1690

Merged
yusuftomilola merged 8 commits into
DistinctCodes:mainfrom
zakariyaufarida5-wq:fix/freighter-deps-dashboard-scan-ci
Oct 17, 2026
Merged

yusuftomilola merged 8 commits into
DistinctCodes:mainfrom
zakariyaufarida5-wq:fix/freighter-deps-dashboard-scan-ci

Conversation

@zakariyaufarida5-wq

Copy link
Copy Markdown
Contributor

Summary

This PR addresses four frontend issues with small, focused changes:

#1622 - @stellar/freighter-api is not a dependency

  • Added @stellar/freighter-api to package.json dependencies so the dynamic import in wallet.store.ts resolves on a clean install.

#1618 - Four duplicate Dashboard component directories

  • Deleted duplicate DashboardCharts.tsx and DateRangeSelector.tsx from components/Dashboard/ and store/Dashboard/.
  • features/Dashboard/ remains the single source of truth with its spec files.

#1608 - Public scan page fetches a relative URL

  • Updated app/scan/[assetId]/page.tsx to use the API base URL (NEXT_PUBLIC_API_URL) via axios instead of a relative fetch('/api/...').
  • Added distinct loading, not-found (404), and connection error states with a retry button.

#1605 - CI runs non-existent ype-check script and never runs tests

  • Added "type-check": "tsc --noEmit" script to package.json.
  • Added a npm run test (Jest) step to frontend-ci.yml.
  • Fixed NEXT_PUBLIC_API_URL to use port 6003 (the backend default).

Closes #1622
Closes #1618
Closes #1608
Closes #1605

@vercel

vercel Bot commented Oct 17, 2026

Copy link
Copy Markdown

@zakariyaufarida5-wq is attempting to deploy a commit to the naijabuz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 17, 2026

Copy link
Copy Markdown

@zakariyaufarida5-wq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@yusuftomilola
yusuftomilola merged commit eec17dc into DistinctCodes:main Oct 17, 2026
0 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment