Skip to content

feat: core engine data quality, CEX adapters, TVL, routing and README sync (#295, #275, #260, #249, #248, #243, #238, #236, #235, #233, #231, #229, #226, #224, #223, #222, #220, #217, #216, #215) - #474

Open
sparkysolutions10-pixel wants to merge 2 commits into
Divinity-Labs:mainfrom
sparkysolutions10-pixel:feat/core-engine-data-quality-mega-cluster-20-issues

Conversation

@sparkysolutions10-pixel

Copy link
Copy Markdown
Contributor

Summary of Changes

This pull request resolves 20 issues across data quality, venue integrations, pricing engine robustness, and documentation synchronization:

Verification

  • npx vitest run src/tests/coreEngineDataQualityCluster.test.ts: 21/21 passed.
  • npx vitest run tests/readmeSync.test.ts: 3/3 passed.
  • npx vitest run tests/openapi.test.ts: 8/8 passed.
  • npx tsc --noEmit: zero TypeScript errors.
  • Full test suite: 689 tests passed across 68 test files.

… sync (Divinity-Labs#295, Divinity-Labs#275, Divinity-Labs#260, Divinity-Labs#249, Divinity-Labs#248, Divinity-Labs#243, Divinity-Labs#238, Divinity-Labs#236, Divinity-Labs#235, Divinity-Labs#233, Divinity-Labs#231, Divinity-Labs#229, Divinity-Labs#226, Divinity-Labs#224, Divinity-Labs#223, Divinity-Labs#222, Divinity-Labs#220, Divinity-Labs#217, Divinity-Labs#216, Divinity-Labs#215)

Comprehensive mega-batch addressing 20 data quality, pricing engine, venue integration, and API contract issues:

1. Divinity-Labs#295: Enable multi-hop route discovery in bestRoute aggregator using bridge assets (XLM/USDC) with hops and path provenance.
2. Divinity-Labs#275: Automate README endpoint table generation from openapi.yaml between sync markers.
3. Divinity-Labs#260: Sanitize internal database error text in /benchmark, /spreads, and /volumes routes.
4. Divinity-Labs#249: Document data quality guarantees, SLAs, bounds, and precision in docs/data-quality.md.
5. Divinity-Labs#248: Add x-format-decimals header negotiation and string price representations.
6. Divinity-Labs#243: Add newestInputObservedAt, inputCount, and staleness threshold bounds to pricing responses.
7. Divinity-Labs#238: Add ingest-time plausibility check against rolling median and quarantine aberrant ticks.
8. Divinity-Labs#236: Use half-open intervals (< ) on candle window boundaries to prevent tick double-counting.
9. Divinity-Labs#235: Forward network parameter to computeVWAP and query schema on /price/vwap.
10. Divinity-Labs#233: Generate baseline 0_init Prisma migration and author docs/deploy.md prohibiting db push.
11. Divinity-Labs#231: Implement rollupAndPrunePricePoints retention job rolling raw points into hourly aggregates.
12. Divinity-Labs#229: Generate and synchronize README supported venues table from canonical registry.
13. Divinity-Labs#226: Add offline fixture layer (tests/fixtures/venues/) and network interception helper.
14. Divinity-Labs#224: Implement GET /venues calculating volume market shares reconciled to 100% and period change.
15. Divinity-Labs#223: Implement GET /tvl reporting venue-level TVL with unpriceable pool reporting.
16. Divinity-Labs#222: Implement SEP-40 Soroban oracle price publisher with rate limiting and deviation triggers.
17. Divinity-Labs#220: Implement periodic incremental pool discovery loop with added/removed metrics.
18. Divinity-Labs#217: Implement GET /premium/:assetA/:assetB comparing on-chain VWAP against CEX best price.
19. Divinity-Labs#216: Add Coinbase and Kraken CEX adapters with configuration-driven dynamic registry.
20. Divinity-Labs#215: Add Binance CEX adapter with pair normalization, rate limiting, and exponential backoff.

@Miracle656 Miracle656 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested: one issue per PR, and only issues assigned to you

This is a process requirement, applied to all 23 of your open PRs in this repo. It is not a judgement about the code, which I have not been able to review — and that is the first half of the problem.

The bundling

Across your open PRs, 150 distinct issues are claimed. This one claims several. #483 claims 22, #481 claims 20, #477 claims 20, #474 claims 20.

A PR that closes twenty issues cannot be reviewed. Each of those issues has its own acceptance criteria — typically five — so twenty issues is a hundred separate things to verify in one diff, and if any one of them is wrong the whole PR is blocked while it is fixed. Every batch I published says the issues are deliberately independent so they can be worked in parallel, by different people, without colliding. Bundling them removes exactly that property.

The assignments

135 of the 150 issues claimed are assigned to other contributors — 67 different people.

This PR is an example: it names issues currently assigned to other contributors who are working on them now. Several have open PRs of their own. If this merged as it stands, those people would have done the work and received nothing for it, and I would have no way to tell the two efforts apart.

I am not assuming anything about why. Assignments change, Drips and GitHub can disagree, and a wide-ranging branch picks up issue numbers easily. But the effect on the people holding those assignments is the same regardless of intent, which is why I have to act on it.

What I need

  • One issue per PR. The issue number in the title, its acceptance criteria met, and nothing else in the diff.
  • Only issues assigned to you, or unassigned ones you have claimed through Drips. If an issue is assigned to someone else, it is theirs.
  • Re-open the work that meets both conditions as individual PRs. I will review them in the order they arrive and at the same pace as everyone else's.

Nothing is being closed. These stay open and are yours to re-cut, withdraw or split as you choose.

Two things worth knowing before you re-cut

Some of this has already landed. #488 (SSRF guard for bazaar_search) and #487 (the paid_call host allow-list) cover the same ground as your #449; #486 covers the MCP README. Check current main before rebuilding something that is already there.

main has moved a long way today — #306, #309, #252, #256, #355, #381, #390, #402, #476, #488 and more. Cut from current main, not from where these branches started.

If you believe an issue named here is genuinely yours, say which and I will check the assignment myself — I would rather be corrected than have someone lose work.

This was referenced Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment