Repository navigation
feat(notifications): add owner-scoped in-app inbox - #167
Open
fredericklamar342-prog wants to merge 1 commit into
Open
fredericklamar342-prog wants to merge 1 commit into
fredericklamar342-prog wants to merge 1 commit into
Conversation
fredericklamar342-prog
force-pushed
the
fix/issue-93-notification-inbox
branch
from
October 19, 2026 20:29
ed8b524 to
f508989
Compare
|
@fredericklamar342-prog Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@fredericklamar342-prog Thanks for the PR. It can't be merged yet. To unblock it: Merge conflicts: this branch conflicts with Push to this same branch and CI will re-run. Once it's green and conflict-free, it'll be reviewed for merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notificationmodel, typed payload validation, provider-agnostic channel adapter registry, and authenticated inbox endpoints with unread filtering, count, read-all, and keyset pagination.Tests
npm run audit:prod— passed (policy-tolerated existing Axios advisories only).npm run typecheck— passed.npm test— passed (93 tests).npm run test:integration— passed (161 tests, including 4 new notification inbox cases).npm run build— passed.npm run test:all— 254 tests passed and 3 skipped, but the optional live-testnet payments suite fails in its setup before skips are applied because its Prisma client uses the default test database URL. CI runs the separate unit/integration commands above and excludestests/testnet-integration/.No new provider configuration is required. The notification migration must be applied with the normal Prisma migration deployment.
Closes #93