Repository navigation
feat(release): build against packages already published in the archive - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A package depending on another of ours cannot be built by the release or edge workflows: the builder knows no published package, so the build stops at the first such dependency. The builder can now read the archive (
ARCHIVE_URLin duatic_devtools'build_pkg.sh), and this passes it.reusable_release_build.yml:ARCHIVE_URLset, it fetches the archive's key from it and uses it only when its one primary key's fingerprint isARCHIVE_KEY_FINGERPRINT;archive_channels, a new input defaulting tostable.ARCHIVE_URL, the build runs as before.reusable_edge_build.ymlbuilds witharchive_channels: edge stable, so a dependency without a build of main comes from its release.Testing
!and means the next release is a major version bump)Notes
ARCHIVE_URLin the builder. Until then the builder ignores it, and a build with such a dependency fails as it does today.ARCHIVE_URLandARCHIVE_KEY_FINGERPRINTare set.