Repository navigation
Conversation
sepandhaghighi
requested changes
Oct 23, 2026
sepandhaghighi
left a comment
sepandhaghighi
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your contributions. Please take a look at my comments.
| :type IStep: float | ||
| :return: filtered range as list | ||
| """ | ||
| if IStep == 0: |
Contributor
There was a problem hiding this comment.
Please remove this section
| [0, 500, 0.1] | ||
| >>> filter_range(500,0,-0.1) | ||
| [0, 500, 0.1] | ||
| >>> filter_range(0,100,0) |
Contributor
There was a problem hiding this comment.
Please remove this section
| - `Python 3.13` added to `test.yml` | ||
| - `Python 3.14` added to `test.yml` | ||
| - Restart mode updated | ||
| ### Fixed |
Contributor
There was a problem hiding this comment.
Move these lines under the ### Changed section.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #261 +/- ##
===========================================
+ Coverage 92.78% 92.81% +0.03%
===========================================
Files 11 11
Lines 1648 1653 +5
===========================================
+ Hits 1529 1534 +5
Misses 119 119 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #260
What does this implement/fix? Explain your changes.
filter_lambda: values below 14 are now set to 14 (previously 23).get_precision: handles scientific notation (1e-05→ 5,1.5e-05→ 6), so small current steps no longer cause an infinite loop.filter_range: raisesValueErrorfor a zero step, so the simulation fails with the usual "Check Your Inputs" message instead of hanging.test/test_Functions.py(the existingfilter_lambda({"lambda":13})test expected the buggy result).CHANGELOG.mdandAUTHORS.mdupdated.Any other comments?
All tests pass locally.