Repository navigation
fix(gameserver): promote unregister summary to Info (#122) - #129
Merged
Merged
Conversation
…ressions surface in production logs (#122) Both the owner-recorded line (gameserver.cpp:944) and the "Unregistered %zu broadcaster callbacks" line (:1125) were Debug, which isn't on by default — the only reason #117's broadcasterOwner-dropped bug went a week unnoticed in production. Promoted the unregister-time line to Info and folded in owner/liveOwner: #117's signature was recordedOwner reading null while liveOwner was a real pointer, so a mismatch between the two now surfaces without enabling Debug logging. Left the registration-time line at Debug since the unregister-time summary now carries the same owner value plus the actual outcome, which is the actionable moment. No other call site or test references either log string by exact text (checked across the whole tree, not just .cpp/.py/.go). Co-Authored-By: nevr-runtime <agents@sprock.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #122. Both the owner-recorded line (gameserver.cpp:944) and "Unregistered %zu broadcaster callbacks" (:1125) were Debug-only, which isn't on by default — the only reason #117's broadcasterOwner-dropped bug (it only cleared a local registry struct without ever reaching the real BroadcasterUnlisten) went a full week unnoticed in production.
Fix
Promoted the unregister-time log to Info, folding in both
owner(recorded at registration) andliveOwner(read back at unregister time): a mismatch between them, orremoved==0with a non-null owner, is exactly the #117 signature — now visible without enabling Debug logging. Left the registration-time line at Debug since the unregister-time line now carries the same owner value plus the actual outcome, which is the moment that matters operationally.Confirmed no other call site or test in the repo references either log line by exact text (grepped
.cpp/.py/.go).Test plan
just verifygreen (mingw-release), 138 tests🤖 Generated with Claude Code