Skip to content

fix(gameserver): promote unregister summary to Info (#122) #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thesprockee merged 1 commit into from
Oct 6, 2026
+9 −1
Merged

fix(gameserver): promote unregister summary to Info (#122) #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/runtime/server/gameserver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,8 +1121,16 @@ void GameServerLib::UnregisterAllCallbacks() {
: GameServer::BroadcasterUnlisten([](EchoVR::Broadcaster* owner, uint16_t handle) {
EchoVR::BroadcasterUnlisten(owner, handle);
});
// Issue #122: this is the line that would have caught #117 in production.
// #117's signature was recordedOwner reading null (never recorded) while
// liveOwner was a real pointer — the mismatch that makes removed stay 0
// with no actual error. It was Debug, which isn't on by default, so that
// week-long silent no-op went unseen.
const EchoVR::Broadcaster* recordedOwner = cb.broadcasterOwner;
const size_t removed = GameServer::UnregisterBroadcasterCallbacks(liveOwner, cb, unlisten);
Log(EchoVR::LogLevel::Debug, "[NEVR.GAMESERVER] Unregistered %zu broadcaster callbacks", removed);
Log(EchoVR::LogLevel::Info,
"[NEVR.GAMESERVER] Unregistered %zu broadcaster callbacks (owner=%p, liveOwner=%p)",
removed, static_cast<const void*>(recordedOwner), static_cast<void*>(liveOwner));
}

VOID GameServerLib::Terminate() {
Expand Down
Loading