Allow admins to attach receipts to approved expenses - #100460
Conversation
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@ChavdaSachin could you please review this PR? |
|
🚧 flaviadefaria has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
flaviadefaria
left a comment
There was a problem hiding this comment.
Looking good to me too!
|
@ChavdaSachin kindly bump |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-09-10.at.4.36.23.PM.movScreen.Recording.2026-09-10.at.4.37.48.PM.mov |
|
@ChavdaSachin can we finish getting this reviewed today? |
|
🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.4.76-0 🚀
|
|
🤖 Yes — help site changes are required. Draft PR: #100903 This PR lets a Workspace Admin attach or replace a receipt on an expense in an Approved report without unapproving it. Three help articles currently state the opposite, so they're now wrong:
What the docs now say: a Workspace Admin can attach or replace a receipt on an Approved report without unapproving. Deleting a receipt still requires unapproving ( Evidence and verificationThe gate is
I ran a dev build of this branch on web to confirm the UI labels used in the new steps. As a Workspace Admin on an approved, receiptless expense, the receipt panel still renders the Add a receipt drop zone (tooltip Upload receipt), the report status reads Approved, and the nav tab is Spend. The replace-an-existing-receipt path couldn't be driven end to end because the browser automation can't complete a native file picker — that path is covered by the unit tests you added in One thing worth a second look: @dukenv0307, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.76-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Allow WS admin to attach/update receipt
Fixed Issues
$ #100459
PROPOSAL:
Tests
Precondition: Have a WS: User A is admin, User B is submitter
Test case 1:
Test case 2:
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-04.at.22.28.15.mov
Screen.Recording.2026-09-04.at.22.36.07.mov