Docs updates for E/A#100542 Add Rillet vendor matching help article - #100899
Docs updates for E/A#100542 Add Rillet vendor matching help article#100899MelvinBot wants to merge 2 commits into
Conversation
Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
|
@MelvinBot mark this PR as ready for review |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@jliexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Done — this PR is now Ready for review (no longer a draft). Two things to flag before a reviewer picks it up:
Checks are green apart from |
|
|
||
| Expensify assigns vendors automatically in the following order: | ||
|
|
||
| - If a workspace merchant rule specifies a vendor, that vendor is assigned. |
There was a problem hiding this comment.
Terminology consistency: Capitalize "Workspace" here ("If a Workspace merchant rule..."). Everywhere else in this article "Workspace" is capitalized as the Expensify feature name; per the naming conventions, UI/feature terminology must be exact and consistent.
There was a problem hiding this comment.
@stephanieelliott - I think Melvin is correct, this should be a capital right?
HelpDot Documentation ReviewOverall AssessmentThis PR adds one new help article, Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
…or matching article Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
|
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai. |
|
No code fix is needed — the What failed: The That's the Ubuntu package mirror refusing connections at Why it's unrelated: This PR changes exactly one file, I couldn't re-run it myself: my token doesn't have The other red check, Check status detail
Note: I diagnosed this from the CI logs and the workflow definition only — browser verification wasn't available in this run, and isn't needed for a docs-only change. |
Explanation of Change
Help site follow-up for #100542, which added Rillet as a vendor matching source (cascade order
QBO → Sage Intacct → Xero → Rillet), wired Rillet-specific empty state copy into the vendor selector, and included Rillet in the Vendors row detection on the More features page.The help site already documents vendor matching per integration — Manage Vendor Matching for QuickBooks Online and Manage Vendor Matching for Sage Intacct — but had nothing for Rillet. This PR adds the matching article:
docs/articles/new-expensify/connections/rillet/Manage-Vendor-Matching-for-Rillet.mdIt covers who can use Rillet vendor matching, how vendors are matched automatically, selecting a vendor manually on an expense, where the imported vendor list lives, setting the Default company card vendor, the export order, and the Vendor no longer valid error.
Notes on the approach:
noindex: true/sitemap: false, matching the Sage Intacct article, because Rillet vendor matching is still gated behind thevendorMatchingbeta (QBO is GA and its article is indexed).Configure-Rillet.md, again matching the Sage Intacct precedent for a beta-gated article.src/languages/en.tson this commit and checked against the live web app: Accounting, More features, Vendors ("Match card expenses to vendors imported from your accounting software."), Default company card vendor, Find vendor, No vendors found, and Vendor no longer valid. Rillet is confirmed present in the Accounting connections list.CONST.NON_REIMBURSABLE_FALLBACK_VENDOR_NAME, so the article stops at the Default company card vendor.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/678897
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
This PR only adds a markdown file under
docs/articles, so there is no app behavior to test. Review should confirm the article matches the current behavior of Rillet vendor matching.Offline tests
N/A — documentation only.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.