Add Rillet support for vendor matching - #100542
Conversation
Add Rillet to vendor matching cascade, wire empty state, and update WorkspaceMoreFeaturesPage.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
ooh to test this we'll need to add your email to the |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Beamanator
left a comment
There was a problem hiding this comment.
Let's move forward with this 👍 I did a decent amount of testing and it's looking great!
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.76-0 🚀
|
|
Yes — help site changes are required, and I've opened a draft PR for them: #100899 Why: the help site documents vendor matching per integration, and it already has articles for QuickBooks Online and Sage Intacct. This PR adds Rillet as a fourth vendor matching source, so the same coverage was missing for Rillet. What the docs PR adds: one new article, Decisions worth a look during review
No changes are needed to any existing help site article — nothing under @ShridharGoel, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.76-1 🚀
Bundle Size Analysis (Sentry): |








Explanation of Change
Adds Rillet support for workspace vendor matching. Extends
PolicyUtilswithisRilletVendorMatchingActive, adds Rillet tohasVendorFeature,getActiveVendorMatchingIntegration,getActiveVendorMatchingVendors, andfindVendorByIDfollowing cascade order (QBO → Sage Intacct → Xero → Rillet). Wires integration-specific empty state copy (workspace.rillet.noVendorsFound) inIOURequestStepVendor, and includes Rillet inWorkspaceMoreFeaturesPagevendor matching connection detection.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/678897
PROPOSAL:
Tests
Prerequisite: A workspace with the
vendorMatchingbeta enabled, Rillet connected and configured, and at least one vendor in Rillet.More Features Page:
Manual vendor pick & search on an expense:
Automatic vendor matching:
Inactive-vendor error:
Offline tests
QA Steps
Same as tests. Must be in
vendorMatchingbeta - feel free to tag @Beamanator and @heyjennahay to test in stagingPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari