[No QA] Docs updates for E/A#99164 Create a rule prompt on expense edits - #100907
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#99164 Create a rule prompt on expense edits#100907MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Adds the in-expense Create a rule prompt shipped in #99164 and corrects the match-type and save-button labels to match the live UI. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
Contributor
Author
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
Merged
54 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://4866c65c.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #99164, which added an in-expense prompt offering to turn an expense edit into a Merchant Rule. Nothing on the help site described that entry point, so admins who saw the prompt had no article explaining what it does or why it sometimes doesn't appear.
Changes to
docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md:## How to create a Merchant Rule from an expense you just edited, covering which field edits trigger the prompt, where it appears on each platform, that the Add rule page opens pre-filled with the merchant and the edited fields (everything else left at Don’t change), that you return to the expense after saving, and how to dismiss the prompt.## Why don't I see the Create a rule prompt after editing an expense?, listing every gate fromsrc/hooks/useMerchantRuleSuggestion.ts: Rules write access, Control plan with Rules enabled, a workspace expense, an expense that already has a merchant, one of the six triggering fields, and an expense detail view rather than a multi-expense report. It also explains that the offer is consumed once dismissed, acted on, or navigated away from.keywordsandinternalScopeto cover the new entry point.The set of triggering fields comes from
CONST.MERCHANT_RULE_SUGGESTION_FIELDSand the prompt copy fromsrc/languages/en.ts.One item needs your confirmation: the prompt itself is gated behind the
rulesRevampbeta, so it could not be exercised on a test account. The behavior documented here is derived from the source and from the test plan in #99164, not from a live capture. The surrounding Rules page labels were verified live.No screenshot was added. The article carries a
<!-- SCREENSHOT: -->suggestion for one showing the prompt above the composer, for whoever can capture it with the beta on.Fixed Issues
$ #96354
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable. This PR only changes a Markdown help article and ships no app code.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.