Repository navigation
feat: keep the candidates and channels a peer signalled - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A NetherNet connection now keeps two more things a peer sent while it connected, next to its offer and its join request:
getRemoteCandidates(): the ICE candidates it signalled after its offer, as received, a line eachgetRemoteChannels(): the data channels it opened, in order: label, stream id and protocol, a line eachBoth are capped (8 KiB and 1 KiB) and read under the connection's lock. A server that inspects connections can pass them on; nothing here judges them.
Checked by compiling the changed sources with the flags of Falcon's build. No test of its own: it needs a live peer connection.
AI disclosure
Written by Claude Fable 5.2 (code).