Repository navigation
Conversation
Member
|
Thank you so much for your first contribution, William, and sorry for the long wait! In the meantime #11 renamed the Lite folders, so your PR could no longer merge as is. I carried your two commits over unchanged into #12, so they're still authored by you, translated both labels into the other 38 languages and added a test. They'll ship with 2.0, and you'll be credited in the release notes. About your question: the "extractionState": "extracted_with_value" lines are normal. Xcode writes them when it syncs a String Catalog with the String(localized:) calls during a build. They're harmless, but no other entry in this catalog carries them, so I removed them in #12 to keep things consistent. Closing this in favor of #12 – thanks again! |
Contributor
Author
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NEW business labels
Hello,
As a first contribution I would like to add some words for business apps. Business objects can have various statuses. This PR adds 2 new labels: Validated & Ordered
These termes have been translated by me to French
I also noticed when building the Swift package, a lot of entries in the string catalogs get:
"extractionState" : "extracted_with_value",added to them. Is this normal ? or not good for project ?Thank you