Skip to content

Add the Ordered and Validated business labels in every language - #12

Merged
Jeehut merged 3 commits into
mainfrom
wip/business-status-labels
Oct 12, 2026
Merged

Jeehut merged 3 commits into
mainfrom
wip/business-status-labels

Conversation

@Jeehut

@Jeehut Jeehut commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Brings the two business status labels from #8 by @W1W1-M into 2.0, translated into every language the package ships.

TK.Label.ordered ("Ordered") and TK.Label.validated ("Validated") are statuses a business app shows on an order, an invoice or a document. The original PR added them with English and French and targeted the TranslateKitBusinessLite folder, which no longer exists since #11. Its two commits were cherry-picked onto main unchanged, so the authorship stays with @W1W1-M; git followed the rename to TranslateKitBusiness on its own.

On top of that:

  • The remaining 38 languages are translated. Apple has no system wording for these two words, so they follow the package's rules for status labels: a short past participle or "done" form, matching the register each language uses elsewhere in the catalog.
  • The comments now say what a translator needs to know: both are statuses ("Use as a status showing that something has been ordered" / "…checked and approved"). "Validated" is translated as "checked and confirmed as valid" rather than "approved", because approved is a different status an app may need next to it.
  • The extractionState: extracted_with_value lines and the new state on the English source are gone. Xcode writes them when it syncs a catalog with the String(localized:) calls during a build; they are harmless, but no other entry in this catalog carries them.
All translations
Language Ordered Validated
ar تم الطلب تم التحقق
bg Поръчано Проверено
ca Encarregat Validat
cs Objednáno Ověřeno
da Bestilt Valideret
de Bestellt Validiert
el Παραγγέλθηκε Επικυρώθηκε
en-AU Ordered Validated
en-GB Ordered Validated
es Pedido Validado
es-419 Pedido Validado
fi Tilattu Tarkistettu
fr Commandé Validé
fr-CA Commandé Validé
he הוזמן אומת
hi ऑर्डर किया गया सत्यापित
hr Naručeno Provjereno
hu Megrendelve Ellenőrizve
id Dipesan Divalidasi
it Ordinato Convalidato
ja 注文済み 検証済み
kk Тапсырыс берілді Тексерілді
ko 주문됨 검증됨
ms Dipesan Disahkan
nb Bestilt Validert
nl Besteld Gevalideerd
pl Zamówiono Zweryfikowano
pt-BR Pedido feito Validado
pt-PT Encomendado Validado
ro Comandat Validat
ru Заказано Проверено
sk Objednané Overené
sv Beställd Validerad
th สั่งซื้อแล้ว ตรวจสอบแล้ว
tr Sipariş Verildi Doğrulandı
uk Замовлено Перевірено
vi Đã đặt hàng Đã xác thực
zh-HK 已下單 已驗證
zh-Hans 已下单 已验证
zh-Hant 已下單 已驗證

How this was verified

A new test reads the compiled TranslateKit_TranslateKitBusiness.bundle and fails for every language whose .lproj lacks one of the two keys (Tests/TranslateKitTests/CompiledCatalog.swift is a small helper the next PRs reuse). It went red with the catalog as of the cherry-picked commits and green with this branch:

# catalog with en + fr only
✘ statusLabelIsTranslatedIntoEveryLanguage(key:) "TK.Label.validated": languagesMissing(…) == []
✘ statusLabelIsTranslatedIntoEveryLanguage(key:) "TK.Label.ordered": languagesMissing(…) == []
✘ Test run with 6 tests in 2 suites failed with 2 issues.

# this branch
✔ statusLabelIsTranslatedIntoEveryLanguage(key:) with 2 test cases passed
✔ Test run with 6 tests in 2 suites passed.

swift test --build-system swiftbuild on Xcode 26.6 / Swift 6.3.3, the same setup as CI.

W1W1-M and others added 3 commits October 12, 2026 09:00
The two business labels arrived with English and French only, so every
other language fell back to English. They now ship in all 40 languages
of the catalog, with comments that tell a translator they are statuses.

A test reads the compiled catalog and fails for any language that lacks
one of the two keys.
@Jeehut
Jeehut merged commit b773473 into main Oct 12, 2026
1 check passed
@Jeehut
Jeehut deleted the wip/business-status-labels branch October 12, 2026 09:30
@Jeehut Jeehut mentioned this pull request Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants