Repository navigation
Add the Ordered and Validated business labels in every language - #12
Merged
Merged
Conversation
The two business labels arrived with English and French only, so every other language fell back to English. They now ship in all 40 languages of the catalog, with comments that tell a translator they are statuses. A test reads the compiled catalog and fails for any language that lacks one of the two keys.
This was referenced Oct 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the two business status labels from #8 by @W1W1-M into 2.0, translated into every language the package ships.
TK.Label.ordered("Ordered") andTK.Label.validated("Validated") are statuses a business app shows on an order, an invoice or a document. The original PR added them with English and French and targeted theTranslateKitBusinessLitefolder, which no longer exists since #11. Its two commits were cherry-picked ontomainunchanged, so the authorship stays with @W1W1-M; git followed the rename toTranslateKitBusinesson its own.On top of that:
approvedis a different status an app may need next to it.extractionState: extracted_with_valuelines and thenewstate on the English source are gone. Xcode writes them when it syncs a catalog with theString(localized:)calls during a build; they are harmless, but no other entry in this catalog carries them.All translations
How this was verified
A new test reads the compiled
TranslateKit_TranslateKitBusiness.bundleand fails for every language whose.lprojlacks one of the two keys (Tests/TranslateKitTests/CompiledCatalog.swiftis a small helper the next PRs reuse). It went red with the catalog as of the cherry-picked commits and green with this branch:swift test --build-system swiftbuildon Xcode 26.6 / Swift 6.3.3, the same setup as CI.