Repository navigation
Tests + CI speedups: ClearLocalData, Playwright workers, PR scope, share-button e2e - #1023
Merged
Merged
Conversation
- Add Vitest coverage for the "clear local data" settings control: confirmation gating, flowstar*-only key removal, walletId preserved, and the success toast. - Raise Playwright CI workers from 1 to 2 to stop serialising the suite. - Run Playwright on chromium-desktop only for pull_request CI runs (full cross-browser matrix stays on pushes to main), and only install the browsers needed for each case. - Rewrite the stream-detail share-button e2e test to visit an existing mock stream (id "1") with a connected wallet and assert on the actual "Share stream" button, instead of a nonexistent stream id. Closes FlowwStar#913 Closes FlowwStar#910 Closes FlowwStar#909 Closes FlowwStar#904 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@yosemite01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Austinaminu2
had a problem deploying
to
staging
October 18, 2026 17:31 — with 
GitHub Actions
Failure
GitHub Actions
Failure
3 tasks
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles fixes for four good-first-issue tickets:
__tests__/components/clear-local-data.test.tsxcovering the "clear local data" control: the confirmation step gates the actual clear, onlyflowstar*-prefixed localStorage keys are removed, non-flowstarkeys likewalletIdare kept, and the success toast reports the cleared count. No production code changes were needed.playwright.config.ts: raised CIworkersfrom1to2so the suite no longer serialises on CI..github/workflows/ci.yml(e2e job): onpull_requestevents, install only thechromiumbrowser and runnpx playwright test --project=chromium-desktop; pushes tomainkeep installing and running the full project matrix.e2e/contract-integration.spec.ts: the "should display share buttons on stream detail" test now connects a mock wallet (samewithWalletpattern used elsewhere ine2e/) and visits/app/stream/1(an existing mock stream fromlib/mock-data.ts) instead of the nonexistent/app/stream/test-id, and asserts ongetByRole('button', { name: 'Share stream' })perlib/copy/stream-detail.ts.Test plan
npm testpasses, including the newclear-local-data.test.tsxcaseschromium-desktopmainstill runs the full browser matrixshould display share buttons on stream detailpasses onchromium-desktopCloses #913
Closes #910
Closes #909
Closes #904
🤖 Generated with Claude Code