Repository navigation
fix(base): copy a const Function instead of wrapping it - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function's converting constructor excluded Function itself but not const Function. Moving a closure that captured a Function by copy moves that capture as a const Function&&, which bound to the converting constructor ahead of the copy constructor and wrapped the Function in another Function, and again, until the stack ran out. rx hits this in Renderer::BuildFrameGraph for every scene hook (the pass lambda captures the hook by copy); anyvoxel crashed on its first frame.
StaticFunction's converting constructor and assignment had no constraint at all, so copying a non-const StaticFunction lvalue failed its storage static_assert.
base_unittests 1005/1005.