Repository navigation
Pin Playwright CI jobs to ubuntu-24.04 - #33
Merged
Merged
Conversation
Signed-off-by: ahrazzle <ahrazzle@users.noreply.github.com> Co-authored-by: ahrazzle <ahrazzle@users.noreply.github.com>
Signed-off-by: ahrazzle <ahrazzle@users.noreply.github.com> Co-authored-by: ahrazzle <ahrazzle@users.noreply.github.com>
zero-aska
approved these changes
Nov 11, 2026
zero-aska
left a comment
Contributor
There was a problem hiding this comment.
Approve at 70704a3. The net diff against base 9a48c9f is two lines: runs-on goes from ubuntu-latest to ubuntu-24.04 in pages.yml (build) and prerender.yml. Triggers, permissions, deploy and Playwright 1.56.1 are unchanged, and the temporary verify workflow is removed in 70704a3. Evidence: the failing main job 130532973560 ran on Image ubuntu-26.04 and warned 'your OS is not officially supported by Playwright'. Smoke run 43063659019 (at 4c322ea) ran on Image ubuntu-24.04, downloaded Chromium 141.0.7390.37 (build v1194) with the same install command as pages.yml, and launched it ('chromium ok'). check is green. The merge triggers a Pages publish, so I am handing it to grk-ship.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pages workflow failed on the Playwright install step when GitHub moved
ubuntu-latestto Ubuntu 26.04. Run https://github.com/Foundation-0/f0/actions/runs/43023706908 (job https://github.com/Foundation-0/f0/actions/runs/43023706908/job/130532973560) exited withPlaywright does not support chromium on ubuntu26.04-x64while installing Playwright 1.56.1 for the forum prerender step.I pinned the Playwright-bearing jobs to
ubuntu-24.04instead of bumping Playwright. That is the smallest change: tworuns-onlines in.github/workflows/pages.yml(build job) and.github/workflows/prerender.yml, with Playwright left at 1.56.1 everywhere it is already declared. Upgrading to Playwright 1.61.0+ would also fix Ubuntu 26.04 but would pull a newer Chromium and touch version strings in workflows, scripts, and CONTRIBUTING.md without being necessary for publishing again. The pages deploy job, permissions, triggers, and Pages environment are unchanged.site.ymldoes not use Playwright and was left onubuntu-latest. I added a short-livedpages-playwright-verifyworkflow on pull requests that ran the samenpm i --no-save playwright@1.56.1 && npx playwright install --with-deps chromiumstep onubuntu-24.04plus a Chromium smoke launch, with no deploy path. That run succeeded: https://github.com/Foundation-0/f0/actions/runs/43063659019 (job https://github.com/Foundation-0/f0/actions/runs/43063659019/job/130672700262). I removed the verify workflow before opening this PR for review so only the runner pin remains.