Repository navigation
fix(persistence): reload persisted records in store order like the Python agent - #60
Merged
Merged
Conversation
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59
I removed the
keys.sort()fromlist_keysinRedisClientHandlerandInMemoryRedisStore(src/persistence.rs).list_keysis only used by the startup reload, so reload now iterates keys in the order the store returns them, as the Python reference does (_load_events_from_redis/_load_metrics_from_redis). The reference only sorts on its limited clear path, which has no counterpart here (clearing is by explicit key or whole namespace). TheInMemoryRedisStore::keysinspection helper stays sorted. The over-capacity handling on reload (evict the oldest buffered item before pushing) already matches the reference. The key stamp isSystemTimeepoch nanoseconds, matchingtime.time_ns(). No docs claimed oldest-first reload, and no test assumed sorted reload.Gate run locally: fmt, clippy -D warnings, tests (default and all features with --include-ignored against Redis), docs, MSRV 1.92 check and test, and the 100% line coverage gate all exit 0.