Skip to content

fix(persistence): reload persisted records in store order like the Python agent #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rennf93 merged 1 commit into from
Oct 15, 2026
Merged

fix(persistence): reload persisted records in store order like the Python agent #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/persistence.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ pub trait RedisHandler: Send + Sync + 'static {
/// Deletes the given records. Missing keys are ignored.
async fn delete_keys(&self, namespace: &str, keys: &[String]) -> Result<(), GuardAgentError>;

/// Lists the short keys currently stored in `namespace`.
/// Lists the short keys currently stored in `namespace`, in the order the
/// store returns them (unsorted, like the Python reference).
async fn list_keys(&self, namespace: &str) -> Result<Vec<String>, GuardAgentError>;

/// Deletes every record in `namespace`.
Expand Down Expand Up @@ -191,12 +192,10 @@ impl RedisHandler for InMemoryRedisStore {
let prefix = format!("{namespace}:");
let mut entries = self.entries.lock().expect("store mutex not poisoned");
entries.retain(|_, entry| !entry.is_expired(now));
let mut keys: Vec<String> = entries
Ok(entries
.keys()
.filter_map(|key| key.strip_prefix(&prefix).map(str::to_owned))
.collect();
keys.sort();
Ok(keys)
.collect())
}

async fn clear_namespace(&self, namespace: &str) -> Result<(), GuardAgentError> {
Expand Down Expand Up @@ -299,12 +298,10 @@ impl RedisHandler for RedisClientHandler {
let mut cmd = redis::cmd("KEYS");
cmd.arg(format!("{prefix}*"));
let full_keys: Vec<String> = self.query(&cmd).await?;
let mut short_keys: Vec<String> = full_keys
Ok(full_keys
.iter()
.filter_map(|key| key.strip_prefix(&prefix).map(str::to_owned))
.collect();
short_keys.sort();
Ok(short_keys)
.collect())
}

async fn clear_namespace(&self, namespace: &str) -> Result<(), GuardAgentError> {
Expand Down
Loading