Repository navigation
fix(dynamic-rules): apply each rule version over the base config - #55
Merged
Merged
Conversation
Each version now restores the base snapshot before applying, so the emergency auto-ban halving no longer compounds and changes from an earlier version do not linger. A failed apply restores the config as it was before the call. Snapshot and restore copy collections. Patterns the registry already holds are skipped. Ports guard-core #169.
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
I ported the reference fix, Guard-Core/guard-core #169. Each dynamic rule version now restores the base snapshot before applying, so the emergency auto-ban halving no longer compounds across versions (16 went 8, 4, 2, and now stays 8), a change from an earlier version no longer lingers when a later version omits it, and expiry restores the true base. A failed apply restores the config as it was before the call. Snapshot and restore now copy collection values like the reference deepcopy, and
suspiciousPatternsthe registry already holds are skipped.I added the 8 reference scenarios in
DynamicRuleOverlayTest. On master 6 of the 8 fail (the failed-apply rollback and collection replacement scenarios already held). The line-keyed coverage waivers forDynamicRuleManager.ktmoved by 9 lines and are re-anchored on identical code. spotlessApply, detekt, build, fullCorpusGate and the 100 percent line coverage gate pass locally.