Repository navigation
fix(core): replace incorrect NoReturn with None type hints - #4
Merged
Merged
Conversation
Three methods annotated -> NoReturn actually return normally: __jsonfiles_present (returns None when files present, only raises on missing files), __init__ (constructors must return None), and pretty_print (prints and returns None). NoReturn means "never returns normally", which caused IDEs/type checkers to flag all code after these calls as unreachable (see issue #2). Fixes #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three methods annotated
-> NoReturnactually return normally:__jsonfiles_present— returnsNonewhen files present, only raises on missing files__init__— constructors must returnNonepretty_print— prints and returnsNoneNoReturnmeans "never returns normally", which caused IDEs/type checkers to flag all code after these calls as unreachable.Also removed the now-unused
NoReturnimport and updated the docstring.Fixes #2