Skip to content

fix(core): replace incorrect NoReturn with None type hints #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Halvani merged 1 commit into from
Aug 21, 2026
Merged

fix(core): replace incorrect NoReturn with None type hints #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions alphabetic/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from jamo import h2j, j2hcj
from pathlib import Path
from enum import Enum, auto
from typing import Union, NoReturn
from typing import Union
from .errors import Non_Existing_ISO_639_2_Langcode

module_dir = os.path.dirname(os.path.abspath(__file__))
Expand Down Expand Up @@ -462,7 +462,7 @@ class Featural (Enum):
Hangul = "Hang",


def __jsonfiles_present(self) -> NoReturn:
def __jsonfiles_present(self) -> None:
"""
Checks the presence of required JSON files and raises an error if any are missing.

Expand Down Expand Up @@ -522,7 +522,7 @@ def __mapping_writing_systems_to_scripts(self) -> dict:
return {ws_name:set(list("".join(["".join(d['script']) for d in script]))) for ws_name, script in writing_systen_map_script.items()}


def __init__(self) -> NoReturn:
def __init__(self) -> None:
self.__jsonfiles_present()
self.writing_systems_to_scripts = self.__mapping_writing_systems_to_scripts()
self.iso_15924_to_iso_639_2_3 = { "Hang" : set(["kor", "jje"]), } # Required for fallback strategy (ISO 639-2/3 language code --> ISO 15924)
Expand Down Expand Up @@ -662,7 +662,7 @@ def is_featural(self, sequence: str, strip_spaces: bool = True) -> bool:
return self.is_writing_system(sequence, self.Featural.__name__, strip_spaces)


def pretty_print(self, script_dict: dict, show_script_key: bool = False) -> NoReturn:
def pretty_print(self, script_dict: dict, show_script_key: bool = False) -> None:
"""
Pretty print the contents of a dictionary where keys are script names and values are lists of characters.

Expand All @@ -675,7 +675,7 @@ def pretty_print(self, script_dict: dict, show_script_key: bool = False) -> NoRe
show_script_key (bool): Whether to print the script name (key) before the characters. Default is False.

Returns:
NoReturn: This function does not return anything. It prints the output directly.
None: This function does not return anything. It prints the output directly.

Example:
>>> script_dict = {
Expand Down
Loading