fix: serialize whole-object request bodies and accept host_config - #23
Merged
Merged
Conversation
Ten methods take their body as one object (containers.create config, the spec of configs, secrets, services, nodes and swarm, volumes.create), but their params models never declared that field. The SDK then sent it as given, in snake_case: containers.create posted exposed_ports instead of ExposedPorts, and Docker silently dropped every such field. The params models now declare the body field with its model, so it is dumped in API names. containers.create also takes host_config, which the Engine API expects in the same body as HostConfig, so callers no longer need extra_body for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ten methods take their request body as one object, but their params models never declared that field, so the SDK sent it as given, in snake_case:
containers.createconfigconfigs.create,configs.updatespecsecrets.create,secrets.updatespecservices.create,services.updatespecnodes.update,swarm.updatespecvolumes.createcreate_requestGo decodes JSON field names case-insensitively, so
imageandcmdhappened to work, but every multi-word field (exposed_ports,cpu_shares, …) was silently dropped by Docker.containers.create: also takeshost_config:, typed with the existingContainer::HostConfig. In the Engine API the create body isContainerConfigplusHostConfigandNetworkingConfigin one object;host_configis merged in asHostConfig.NetworkingConfighas no model in the SDK and is left out.containers.createandsecrets.create; both fail before the change.rake lint(rubocop, Sorbet, Steep) andrake test(184 runs, 0 failures) pass.🤖 Generated with Claude Code