Skip to content

Require completed progress before awarding mission rewards - #7

Closed
tj (tjkilgore93-stack) with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-code-for-review-comment
Closed

tj (tjkilgore93-stack) with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-code-for-review-comment

Conversation

Copilot AI commented Oct 13, 2026 •

Copy link
Copy Markdown

Realtime mission claims previously advanced progress to the target, allowing rewards without completing the mission.

  • Claim validation: Require stored progress to meet the mission target before awarding rewards.
  • Progress preservation: Mark eligible missions as claimed without changing their recorded progress.
if (!(currentProg.progress >= mission.target)) return

@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperfy Ready Ready Preview Oct 13, 2026 12:16am UTC

Co-authored-by: tjkilgore93-stack <313495784+tjkilgore93-stack@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code based on review comment Require completed progress before awarding mission rewards Oct 13, 2026

@vercel vercel Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

POST /api/progression/claim awards mission rewards without verifying the mission target was met, letting users claim XP/tier/cosmetic rewards for incomplete missions.

Fix on Vercel

This branch was successfully deployed

1 active deployment
Preview — ebc6c63a Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants