Skip to content

Require completed progress before awarding mission rewards #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Require completed progress before awarding mission rewards #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6547b74
Initial plan
Copilot Oct 13, 2026
ebc6c63
Require completed progress for mission claims
Copilot Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/core/systems/ServerNetwork.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,10 +706,11 @@ export class ServerNetwork extends System {

const currentProg = missionProgress[missionId] || { progress: 0, completed: false, claimed: false }
if (currentProg.claimed) return // already claimed
if (!(currentProg.progress >= mission.target)) return

// Mark completed and claimed
// Mark the completed mission as claimed
missionProgress[missionId] = {
progress: Math.max(currentProg.progress, mission.target),
...currentProg,
completed: true,
claimed: true,
claimedAt: moment().toISOString(),
Expand Down
Loading