Repository navigation
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Preserve ocean_waves commits, original authors and asset attribution; merge POSIM main e05a9fb without replacing its CI or platform updates. The retained ocean-waves project still targets Harmonic and needs Jetty integration and runtime validation. Source: IOES-Lab/dave#27
Escape the literal ampersand in the Duck tutorial URL so model.config is well-formed XML. Remove only two EOF blank lines reported by git diff --check. Preserve author and asset attribution; no wave simulation behavior is changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and provenance
Continue the ocean-wave and WAM-V contribution in POSIM while preserving POSIM's current platform and repository configuration.
154887e306fb1c0403057ec7dc6d1603a33116a6.e05a9fb7d25ec21399f897e9bddfcabc4493b703.What is carried over
Ocean-wave simulation/rendering sources and tests, WAM-V descriptions and bridge configuration, wave/world-model assets, resource hooks, and the additional wave/WAM-V worlds. The diff contains 234 files against the pinned POSIM baseline.
POSIM integration decisions
dave_ocean_waves.world's maximum step size (0.001→0.01) while preserving POSIM's newer geographical coordinates and GUI camera configuration. The step-size change still needs simulation review.&in the Duck model metadata URL and remove two trailing blank lines reported bygit diff --check. No simulation algorithm was rewritten.Checks and remaining work
git diff --check, changed Python syntax, and XML syntax for 54 changed XML/SDF/world/config/mesh files pass. XML parsing is not Gazebo semantic validation.gz-sim8,gz-rendering8,gz-transport13, etc.). Its discovery/build/install integration with the parent package needs review.Draft / CI note: migration commits use
[skip ci]to avoid automatically starting long self-hosted builds before the imported code is reviewed. Repository CI/publication settings were not changed. Before marking this ready, push a follow-up commit without the skip marker and run the required checks.The original DAVE PR remains open until the migration is reviewed and closure is coordinated.