Repository navigation
kb init(afd-plugin): skeleton - #268
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c20683b8c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - [AFD plugin 仓库规则](rules-init.md) | ||
| - [上游 API 漂移与兼容边界（afd-plugin）](rules-seed-vllm-omni-rebase-upstream-api-drift.md) |
There was a problem hiding this comment.
For Direct reviews of connector or compatibility changes, adapters/afd_plugin/manifest.yaml routes to the corresponding component page and the briefing includes only rules.md plus _index.md; _review_knowledge() never returns either of these newly linked pages. Consequently constraints such as AFD-I1–I3/I10 and AFD-I13–I23 are absent from the review context for precisely the files they govern. Split or merge them into the nearest routed component rules.md pages, rather than relying on links from the repository index.
AGENTS.md reference: AGENTS.md:L12-L17
Useful? React with 👍 / 👎.
| ## AFD-I13 — vLLM 目标版本写在多处，注册期只告警：改 pin 时所有守卫要一起改 | ||
|
|
||
| - 目标版本 `0.26.0` 同时写在三类位置：`pyproject.toml` 的 `vllm` extra（`vllm==0.26.0`）、`afd_plugin/compat/vllm.py` 的版本检查、README 与设计文档里的支持声明。PR 改了其中一处，其余位置必须跟着改。版本守卫有变化时，还要补 package 兼容测试 `tests/unit/package/test_package.py`。 | ||
| - 插件注册调用版本检查时用的是 `strict=False`，版本不匹配只打 warning，然后继续运行。因此“新版本上插件能注册”或“单测能通过”都不算支持证据。在签名不同的上游上跑通的单测，也不算兼容证据。 | ||
| - `config_validation.py` 和 `async_dp_forward_context.py` 放行三种情况：目标版本、dev 版本、缺失版本元数据。 | ||
| - `async_dp_engine.py` 的一般 async 绑定沿用 target/dev 守卫，但其中复制的 coordinator 只在版本恰好是 `0.26.0` 时生效。更新的 dev 版本会保留原生 coordinator。 | ||
| - 所以 bump pin 的 PR 必须显式更新这个 exact 守卫及其测试。否则 async-DP Attention 的行为会悄悄变掉，而且不会报错。 |
There was a problem hiding this comment.
AFD-I13 repeats the version-pin, strict=False, and exact coordinator-guard requirements added simultaneously under AFD-I5; the same page also duplicates AFD-I4 as I18 and AFD-I11 as I23. Keeping synonymous constraints under separate IDs and pages lets later edits or review coverage disagree about which copy is authoritative. Fold each rule's unique details into the existing owner rule before adding another ID.
AGENTS.md reference: AGENTS.md:L7-L11
Useful? React with 👍 / 👎.
kb initstage skeleton forafd-plugin(vllm-project/afd-plugin).9cae2d2ddaae7e1752fc12ead577d59540b17f271d84a91fe9446476dc29664a6f3eebfcf8778b67Human-merged. Rules were screened by the docs redundancy filter, checked at the pin, and given an advisory verdict;
failrules are already removed.repos/afd-plugin/rules-init.mdrepos/afd-plugin/rules-init.mdrepos/afd-plugin/rules-init.mdrepos/afd-plugin/rules-init.mdrepos/afd-plugin/components/compatibility/rules.mdrepos/afd-plugin/components/compatibility/rules.mdrepos/afd-plugin/rules-init.mdrepos/afd-plugin/rules-init.mdrepos/afd-plugin/rules-init.mdrepos/afd-plugin/rules-init.mdrepos/afd-plugin/rules-init.mdrepos/afd-plugin/rules-init.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdSeeds (adapted, provenance only here):
repos/vllm-omni/rebase/upstream-api-drift.md@1d84a91fe944→repos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.md(AFD-I13, AFD-I14, AFD-I15, AFD-I16, AFD-I17, AFD-I18, AFD-I19, AFD-I20, AFD-I21, AFD-I22, AFD-I23)Dropped rules
VLLM_USE_V2_MODEL_RUNNER=0，但所给 Known gaps 证据只声明 V2 不受支持；设置命令仅见 README L180–L185，且该处只明确谈 GPU。见 README L65–L68、L180–L185。其余 V2 约束与测试证据见 attention_runtime.md L139–L162、ffn_runtime.md L129–L148、e2e_testing.md L105–L111。", "non_contradictory": "与 AFD-I7、AFD-I8 关于 V2 配对Needs human edit:
Notes: