Repository navigation
Tests: pin afd-plugin's shadow-only invariant, not its enabled flag - #271
Merged
Merged
Conversation
Two tests asserted the afd-plugin adapter has knowledge_lifecycle enabled: false. kb init's deepen stage flips exactly that key to true (design kb-init, PR 3), so its knowledge PR #270 failed CI on those two assertions, which a knowledge PR cannot touch. The invariant both tests meant is that afd-plugin never auto-merges: they now assert mode == shadow and not auto_merge, which holds on either side of the flip. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two tests asserted the afd-plugin adapter has
knowledge_lifecycle.enabled: false. kb init's deepen stage flips exactly that key to true (design kb-init, PR 3), so its knowledge PR #270 failed CI on those two assertions, which a knowledge PR cannot touch. The invariant both tests meant is that afd-plugin never auto-merges: they now assertmode == "shadow" and not auto_merge, which holds on either side of the flip.Unblocks #270 (re-run its checks after this merges).
🤖 Generated with Claude Code