Skip to content

Tests: pin afd-plugin's shadow-only invariant, not its enabled flag #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tzhouam merged 1 commit into from
Sep 30, 2026
Merged

Tests: pin afd-plugin's shadow-only invariant, not its enabled flag #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/test_kb_init_pilot_afd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@

def test_afd_plugin_init_block_is_valid_on_the_real_tree():
lifecycle = load_registry(adapters_root())["afd-plugin"]
assert lifecycle.enabled is False and lifecycle.mode == "shadow" # init flips it, not this PR
# kb init's deepen stage flips `enabled` to true (design §9 PR 3); this test
# pins the invariant either side of that flip: shadow, never auto_merge
assert lifecycle.mode == "shadow" and not lifecycle.auto_merge
init = lifecycle.init
assert init is not None
assert init.source_roots == ("afd_plugin/",)
Expand Down
3 changes: 2 additions & 1 deletion test/test_kb_service_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ def test_shipped_adapters_register_with_repo_neutral_config():
assert omni.enabled and omni.mode == "shadow" and not omni.auto_merge
assert omni.release.trigger == "github_release" and omni.release.auditor == "release_audit.py"
assert (omni.adapter_dir / omni.release.auditor).is_file()
assert registry["afd-plugin"].enabled is False
afd = registry["afd-plugin"] # kb init flips `enabled`; shadow-only is the invariant
assert afd.mode == "shadow" and not afd.auto_merge
assert registry["general"].intake.merged_prs is False


Expand Down
Loading