Skip to content

Add Data to get device base rigid and device bouding box. Also add visual mesh and update demo scene to display tool base and stylus - #35

Merged
th-skam merged 5 commits into
mainfrom
visual_ref
Sep 9, 2026
Merged

th-skam merged 5 commits into
mainfrom
visual_ref

Conversation

@epernod

@epernod epernod commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Add simple meshes to illustrate device base position and stylus orientation in demo scene

Add bounding box display to get tool workspace

SOFA.-.Inverse3.Demo-01.DeviceMotion.scn.2026-09-08.23-19-55.-.0.00.02-0.00.20.mp4

@epernod epernod added pr: new feature pr: status to review To notify reviewers to review this pull-request labels Sep 8, 2026
@th-skam
th-skam self-requested a review September 9, 2026 07:25
Comment thread src/SofaHaplyRobotics/Haply_Inverse3Controller.cpp Outdated

@epernod epernod left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix wrong comment automatically generated from copilote.

Comment thread src/SofaHaplyRobotics/Haply_Inverse3Controller.h Outdated
Comment thread src/SofaHaplyRobotics/Haply_Inverse3Controller.h Outdated
Co-authored-by: erik pernod <erik.pernod@gmail.com>
@epernod
epernod requested a review from th-skam September 9, 2026 15:42

@th-skam th-skam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my end, stylus rotates and is visible.
Got confused by the "ori"Device to mean orientation.

@th-skam th-skam added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 9, 2026
@th-skam
th-skam merged commit 293bca3 into main Sep 9, 2026
9 checks passed
@epernod
epernod deleted the visual_ref branch September 14, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new feature pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants