Repository navigation
Support Dart 3.9 / Flutter 3.35, release 0.0.2 - #4
Merged
Merged
Conversation
Nothing in the plugin needs Dart 3.10. Lower the SDK floor to 3.9 (Flutter 3.35), allow meta 1.16 (pinned by Flutter 3.35) and pigeon 26, which is only used to regenerate the bindings. CI runs on the oldest supported Flutter, 3.35.6.
FlutterImplicitEngineDelegate only exists from Flutter 3.38, so the example's iOS runner didn't build on 3.35. Registering in application(_:didFinishLaunchingWithOptions:) works on 3.35 and later, also with the scene lifecycle (the plugins go to the launch engine).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowers the SDK floor from Dart 3.10 to Dart 3.9 (Flutter 3.35). Nothing in the plugin needs 3.10.
environment:sdk >=3.9.0 <4.0.0,flutter >=3.35.0(plugin and example).meta: ^1.16.0: Flutter 3.35 pins meta 1.16.pigeon: ">=26.3.4 <28.0.0"(dev only, for regenerating the bindings): 27 needs Dart 3.10. The generated code is unchanged.tool/release.sh check v0.0.2passes).Checked locally on 3.35.6 and 3.47: analyze clean, 32 tests pass; publish dry run 55 KB.
After merge:
tool/release.sh tagpublishes 0.0.2. nav_dock's adapter needs it for its own lower floor.