[JarryShaw]

Please follow the guide below

• You will be asked some questions, please read them carefully and answer honestly

• Put an x into all the boxes [ ] relevant to your pull request (like that [x])

• Use Preview tab to see how your pull request will actually look like

• Searched for similar pull requests

• Followed the coding style (make pylint, make mypy, make isort)

• make test passes, and a test case covers the change

• Added a changelog entry under docs/source/changelog/ and regenerated CHANGELOG.md, if the change is user-visible — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

Tick the commit type your subject line carries.

• fix — corrects a defect
• feat — adds a feature
• perf — changes performance, not behaviour
• refactor — changes neither behaviour nor performance
• test — tests only
• docs — documentation only
• ci — workflows or build tooling
• release — bumps the version or rolls up a distribution
• chore — anything else

---

Description of your pull request and other information

Closes #1602.

Adds 'hold_warnings' beside 'warn' in pcapkit.utilities.warnings.__all__. The class name and its # pylint: disable=invalid-name stay, per the ruling on #1599.

New test test_hold_warnings_is_exported (#1580's test file) asserts the entry and that import * brings the class in. Without the entry it fails: AssertionError: 'hold_warnings' not found in ['warn', 'BaseWarning', ...].

I ran narrow selections only, and all passed: that file, tests/project/test_all_exports_unit.py, test_public_api.py and test_isort_clean.py. make test was not run, so that box is unticked.

[JarryShaw]

Verdict: GOOD TO GO at db0b592af. This was a Sonnet cross-review; the author ran on Opus.

• Scope: one commit on 931960f21, 2 files, +10/−1. The only source change adds 'hold_warnings' beside 'warn' in pcapkit/utilities/warnings.py:78. The class name stays, per the refactor(utilities): rename hold_warnings to HoldWarnings #1599 ruling.
• Fail-before: on main the new test fails with 'hold_warnings' not found in ['warn', 'BaseWarning', ...]. It passes on the head.
• Exports: a diff of the __all__ lists and the star-import namespace on both trees shows that only pcapkit.utilities.warnings gains hold_warnings. pcapkit.__all__, pcapkit.all.__all__ and pcapkit.utilities.__all__ are unchanged.
• Narrow runs pass: test_trial_parse_warnings_1580_unit.py, test_all_exports_unit.py, test_public_api.py, test_isort_clean.py.

[github-actions]

Coverage: 89.63% (unit tier, Python 3.14, db0b592af, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	3	20	3	95.16%
pcapkit/const	18858	956	2366	870	91.04%
pcapkit/corekit	2366	67	760	35	96.48%
pcapkit/dumpkit	275	3	100	3	98.40%
pcapkit/foundation	2855	154	1004	42	93.57%
pcapkit/interface	138	7	52	5	93.68%
pcapkit/protocols	16996	227	4540	192	98.04%
pcapkit/toolkit	800	123	282	6	83.27%
pcapkit/utilities	494	4	146	4	98.75%
pcapkit/vendor	4409	2342	1006	157	43.25%

Per-file detail: the coverage-html artifact of this run.