Skip to content

fix(utilities): export hold_warnings in pcapkit.utilities.warnings.__all__ (#1602) #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JarryShaw merged 1 commit into from
Oct 10, 2026
Merged

fix(utilities): export hold_warnings in pcapkit.utilities.warnings.__all__ (#1602) #1603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pcapkit/utilities/warnings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
HeldWarning = Tuple[Union[str, Warning], Type[Warning], Optional[FrameType]]

__all__ = [
'warn',
'warn', 'hold_warnings',

# UserWarning
'BaseWarning',
Expand Down
9 changes: 9 additions & 0 deletions tests/protocols/test_trial_parse_warnings_1580_unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,15 @@ def test_filters_and_registries_are_untouched(self) -> None:
self.assertEqual(len(unrelated), 1)
self.assertEqual(self._schema(caught), TCP_CUT_MESSAGES)

def test_hold_warnings_is_exported(self) -> None:
"""``import *`` brings ``hold_warnings`` in, as it does ``warnings.catch_warnings`` (#1602)."""
import pcapkit.utilities.warnings as warnings_module

self.assertIn('hold_warnings', warnings_module.__all__)
namespace = {} # type: dict[str, Any]
exec('from pcapkit.utilities.warnings import *', namespace) # pylint: disable=exec-used
self.assertIs(namespace['hold_warnings'], warnings_module.hold_warnings)


if __name__ == '__main__':
unittest.main()
Loading