[JarryShaw]

Please follow the guide below

• You will be asked some questions, please read them carefully and answer honestly

• Put an x into all the boxes [ ] relevant to your pull request (like that [x])

• Use Preview tab to see how your pull request will actually look like

• Searched for similar pull requests

• Followed the coding style (make pylint, make mypy, make isort) (run on the touched modules)

• make test passes, and a test case covers the change (narrow runs only, below)

• Added a changelog entry under docs/source/changelog/ and regenerated CHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

Tick the commit type your subject line carries.

• fix — corrects a defect
• feat — adds a feature
• perf — changes performance, not behaviour
• refactor — changes neither behaviour nor performance
• test — tests only
• docs — documentation only
• ci — workflows or build tooling
• release — bumps the version or rolls up a distribution
• chore — anything else

---

Description of your pull request and other information

packet_byteorder and byteorder_callback move from pcapkit/protocols/schema/misc/byteorder.py to pcapkit/corekit/fields/byteorder.py. Per the owner's ruling, nothing is re-exported at the old path.

• Breaking: importing pcapkit.protocols.schema.misc.byteorder now raises ModuleNotFoundError. That module shipped in 1.5.0b9 to b12 with its own docs page and __all__, though never in a stable release. The subject carries !, following the OSPF/RARP precedent (30714cd51).
• Why corekit/fields/: the callback sets NumberField._byteorder, and packet_byteorder reads the __packet__ key that SchemaField builds. At runtime the module imports only sys and typing, so there is no cycle.
• Updated references: frame.py, pcapng.py, corekit/fields/misc.py, examples/generators/endian.py and four tests now import from corekit. A git grep of the old dotted and slash paths finds only the new test's OLD_PATH.
• Docs: the page moves to corekit/fields/byteorder.rst. The old page and its toctree entry are removed, and the Sphinx warning count is unchanged.
• Tests: tests/corekit/test_fields_byteorder_1519_unit.py asserts that the old path raises ModuleNotFoundError. That test fails on 94bce816b, the head that still had the re-export.
  • tests/protocols/misc: 230 passed.
  • The touched modules pass on 3.8, 3.9, 3.10, 3.11 and 3.14.

Closes #1711

[JarryShaw]

Verdict: GOOD TO GO at 94bce816b. A Sonnet cross-review confirmed the following.

• Moved, not changed: packet_byteorder and byteorder_callback now live in pcapkit/corekit/fields/byteorder.py, and the function bodies are byte-identical to the old module's.
• Old path still works: pcapkit.protocols.schema.misc.byteorder re-exports the very same objects (is), so the move is not breaking.
• No import cycle: 9 modules each imported alone in a fresh process, on 3.8, 3.9, 3.10 and 3.14 (36 runs).
• Same output: 23 sample captures parse to identical per-frame fingerprints, and every PCAP record header rebuilds byte-exact in both byte orders.
• Tests: tests/protocols/misc/ passes 230 tests. Sphinx shows the same 63 warnings as main.

[github-actions]

Coverage: 89.42% (unit tier, Python 3.15, 51d07f7cc, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	3	20	3	95.16%
pcapkit/const	18860	954	2368	868	91.06%
pcapkit/corekit	2381	67	764	35	96.50%
pcapkit/dumpkit	275	3	100	3	98.40%
pcapkit/foundation	2887	144	1012	34	94.20%
pcapkit/interface	138	7	52	5	93.68%
pcapkit/protocols	17172	226	4588	190	98.07%
pcapkit/toolkit	1313	280	532	5	75.88%
pcapkit/utilities	500	4	150	4	98.77%
pcapkit/vendor	4417	2342	1010	157	43.38%

Per-file detail: the coverage-html artifact of this run.

[JarryShaw]

Do not re-export. Directly update the import paths.

[JarryShaw]

Recorded: no re-export. pcapkit/protocols/schema/misc/byteorder.py goes, and every import site, docs reference and test moves to pcapkit/corekit/fields/byteorder.py. A worker is on it in this branch.

[JarryShaw]

Done: there is no re-export. pcapkit/protocols/schema/misc/byteorder.py and its docs page are removed, and every import site now uses pcapkit/corekit/fields/byteorder.py.

Verdict: GOOD TO GO at 51d07f7cc. A Sonnet cross-review (the author was Opus) checked 0092e6f29. 51d07f7cc differs from it only by the ! in the subject; the tree is identical.

• Old path gone: git grep/grep -rI for the dotted, slash and backslash forms finds only the new test's OLD_PATH.
• Imports and docs: fresh interpreters on 3.8 to 3.11 and 3.14 import cleanly with no cycle. Sphinx gives 63 warnings both before and after, nothing links to the removed page, and objects.inv lists only the new module.
• Fail before: the negative test fails on 94bce816b (ModuleNotFoundError not raised) and passes now.
• Breaking: the old path shipped in 1.5.0b9 to b12, documented and with its own __all__. That counts as a public-path change under the label rules, so this PR carries breaking and a !.