Repository navigation
refactor(util): move ci_timing and vendor_test_gate onto the Actions helper (#2047) - #2063
Merged
Merged
Conversation
…helper (#2047) - util/ci_timing.py: its annotations go through util/_actions.py. Those that carry text from elsewhere (an API error, the stopped-early note, a finding) stay unescaped, escape=False, as before; output is unchanged. - util/vendor_test_gate.py: annotations, the per-run ::group::, the step summary and the verdict output go through the helper; its own escape() goes, the helper's escaping being the same. Output is unchanged. - tests/project/test_actions_helper_2047.py lists both scripts. - util/python_versions.py stays as it is: several workflows check it out alone, and create-release.yml runs a released copy of it by itself, so it cannot import the helper.
Owner
Author
|
GOOD TO GO at
Pre-existing, not changed here: |
Owner
Author
|
Ready to merge at |
Contributor
|
Coverage: 91.52% (unit tier, Python 3.15,
Per-file detail: the |
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
refactor— restructures code without changing behaviourDescription of your pull request and other information
The third batch for #2047:
util/ci_timing.pyandutil/vendor_test_gate.pymove ontoutil/_actions.py, with byte-identical output.ci_timing.py: annotations go through_actions.annotate. The three that carry outside text keepescape=False, since escaping them would change output.vendor_test_gate.py: annotations, the per-run::group::, the step summary and theverdictoutput use the helper. Its localescape()is gone, because the helper gives the same bytes.util/python_versions.py. Sparse checkouts in three workflows fetch that file alone, andcreate-release.ymlruns an old release's copy extracted withgit show, so there is no_actions.pybeside it.main's copies:vendor_test_gate: 22 adversarial cases, each on 3.7 and 3.14, comparing exit code, stdout, stderr, outputs, summary andgit status. The only difference is the line numbers in a SIGINT traceback.ci_timing: 16 cases on 3.14, since both copies needtomllib.SCRIPTSandRUNSintest_actions_helper_2047, rebased onto ci: post the CodeQL report to Discussions (#2030) #2058'scodeql_reportentry. That file plustest_ci_timing,test_vendor_test_gate_1853,test_codeql_report_2030andtest_ktlo_legs_stay_green_1672:163 passed.