Repository navigation
ci: keep workflow and release-doc comments in step with the ruleset and pins (#2231) - #2249
Merged
Merged
Conversation
…nd pins (#2231) - cron-vendor.yml: the "Install and Setup" and "Commit changes" comments state the current behaviour instead of change-relative history, keeping #910 and #1685 as references. - unit-tests.yml: the comment above `required-checks` lists `Lint`, which ruleset 23497679 also requires. - action-gh-release citations name 3.0.3, the pinned version (its src/github.ts differs from 3.0.2 only in error handling), or no version where the pin sits in the same file. Also covers the releasing.rst item of #2228: the `:631-647` third-party line citation becomes `release()`, and its BARE_ELSEWHERE entry in test_unit_tests_queue is dropped. Comments and docstrings only; every workflow loads to the same data (modulo shell comment lines in cron-vendor's run blocks). tests/project and test_docstring_contract pass; actionlint is clean.
JarryShaw
added
docs
Owner
Author
|
Review: GOOD TO GO at
|
JarryShaw
added
review: good-to-go
Contributor
|
Coverage: 91.56% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
|
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
ci— CI configurationDescription
Closes #2231, and the
releasing.rstpart of #2228 (#2242 carries the rest).cron-vendor.yml: the "Install and Setup" and "Commit changes" comments state current behaviour (design: write down what belongs in theallextra, and why #910, fix(ci): Vendor Update bumps for a new const module but never commits it #1685).unit-tests.yml: the comment aboverequired-checkslistsLintbeside theCompatlegs, as ruleset 23497679 requires.releasing.rst,cron-conda.ymland thetest_release_tags_the_run_sha_1634docstrings cite 3.0.3.create-release.ymldrops the version, since its pin sits beside it. Thev3.0.2...v3.0.3diff changes only error handling.releasing.rst's:631-647third-party line citation namesrelease()instead, and itsBARE_ELSEWHEREentry intest_unit_tests_queue.pygoes.create-release.yml,cron-conda.ymlandunit-tests.ymlload to equal data.cron-vendor.yml's comments sit insiderun:strings, and with shell comment lines dropped it is equal too.test_unit_tests_queuefails onorigin/main('631-647' … cites these bare).tests/projectand the docstring contract give 2048 passed. actionlint is clean.