Repository navigation
refactor(protocols): reorder misc, schema and base class members to the member-order convention (#2490) - #2539
Merged
Conversation
4 of 14 tasks
JarryShaw
added
refactor
Owner
Author
|
Cross-review (Sonnet) of all four #2490 branches, this one at |
Contributor
|
Coverage: 93.94% (unit tier, Python 3.15,
Per-file detail: the |
…he member-order convention (#2490) - protocol: move _packing_target and _next_layer_entry out of Methods, and _make_data to the head of Utilities. - pcap frame/header: move Frame.__index__ into Data models and its private helpers into Utilities after _make_data; move Header.from_data into Methods. - pcapng: move _make_data to the head of Utilities, then the helpers read() calls directly, in first-use order (_read_block_short with its maker). - schema: put Methods ahead of Data models in Schema, EnumSchema, Option, FlagsField, OptionEnumField and SystemdJournalExportBlock; put the IPv6 schema's TYPE_CHECKING __init__ stub after post_process. Pure move: member set, member ASTs and comments are unchanged.
Owner
Author
|
Resolve conflicts |
Owner
Author
|
Conflicts resolved, as asked:
|
JarryShaw
force-pushed
the
refactor/2490-member-order-misc-schema-protocol
branch
from
November 1, 2026 16:25
149775b to
6a949ca
Compare
JarryShaw
removed
the
review: good-to-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseconst— regenerates constant or registry tables, members keeping their numeric valuesDescription of your pull request and other information
Part of #2490. A pure reorder to
protocol-member-order.rst, coveringpcapkit/protocols/protocol.py,misc/pcap/frame.py,misc/pcap/header.py,misc/pcapng.py,schema/schema.py,schema/misc/pcapng.pyandschema/internet/ipv6.py. An AST check confirms the member set, every member body and the comments are unchanged; only the order differs.