Repository navigation
Update profile processing routines - #215
Merged
Merged
Conversation
…profiles Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rofile specifications
…profiles Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
aelligp
force-pushed
the
profile_processing_mt
branch
from
October 5, 2026 12:42
30d6b88 to
d1b634a
Compare
aelligp
requested changes
Oct 5, 2026
Comment on lines
+460
to
+461
| # we do not have this implemented | ||
| #error("horizontal profiles not yet implemented") |
Contributor
Author
There was a problem hiding this comment.
This caused issues when creating horizontal profiles. I now simply add the entire topography to TopoData instead of intersecting the topography with the horizontal slice and issue a warning.
Contributor
Author
|
The failing tests relate to packages outside of GMG, therefore I go ahead and merge. |
aelligp
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whats the purpose of this PR?
Describe it in more detail below:
Profile processing required to merge the volume data sets before creating profiles, which was an issue when there were a lot of volume data sets. In this case, the processing became very slow. I added functions to circumvent this issue. Now the volume data sets can be passed as named tuples (in the same way as surface and point data is processed).
In addition, profile processing functions did not take into account topography data. I fixed that isse by adding the respective field in the ProfileData structure and by adding the topography data fields as input arguments to the respective functions.
I have started to add some tests. However, to test the topogrpahy, I'd need to load some topography data and I am not sure where this resides on the seafile folder.
Checklist
[BUGFIX],[ADDITION],[DOC], etc.