Repository navigation
fix(macos): use web's light panel backdrop and center the welcome panel - #4718
Merged
Merged
Conversation
Web OverlayPanel dims with bg-background/85 over a small blur, so the calendar shows faintly behind settings and welcome. PanelBackdropView used the dark HUD material and the 40% overlay-backdrop dim meant for menus, which read as solid gray. Tint with the 85% background over a window-background blur instead. Web also centers the welcome panel vertically; macOS pinned it to the top. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GKHjv2HDx1DFAnG4cfSxcr
tyler-dane
marked this pull request as ready for review
October 22, 2026 02:48
tyler-dane
added
the
agent-automerge
Claude
tyler-dane
enabled auto-merge
October 22, 2026 02:48
tyler-dane
added
the
parity-screenshots
Claude
The welcome modal's buttons pair a title with a keycap chip and had no explicit label, so accessibility read "Get started for free, Enter". The onboarding parity capture added in #4707 clicks buttons["Get started for free"] and fails on every run since. Label each welcome button with its title; the keycap is a visual hint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GKHjv2HDx1DFAnG4cfSxcr (cherry picked from commit 5d42363)
… panel With the welcome buttons named by title, buttons["Next"] also matched the grid's week "Next" button behind the modal, so the click failed with multiple matches. Query the buttons inside compass-native-welcome-modal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GKHjv2HDx1DFAnG4cfSxcr (cherry picked from commit 77e87f4)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GKHjv2HDx1DFAnG4cfSxcr (cherry picked from commit b031ea7)
The onboarding capture exports onboarding-welcome-account-choice, but the name was not a ParityCaptureSurface, so the debug URL never parsed and the export timed out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GKHjv2HDx1DFAnG4cfSxcr (cherry picked from commit 07b3cce)
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 22, 2026
# Conflicts: # docs/features/desktop-web-parity-checklist.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4331
What and why
In the parity compare (run 39704640345), the macOS settings and onboarding-welcome surfaces sat on an opaque gray backdrop. Web's
OverlayPanelbackdrop isbg-background/85 backdrop-blur-sm, so the calendar shows faintly through a light, warm tint. macOS'sPanelBackdropViewused the dark.hudWindowmaterial plusoverlayBackdrop(hsl(40 25% 15% / 40%)), the dim web reserves for menus and confirm dialogs. Web also centers the welcome panel vertically (items-center, scrolling withpy-8only when needed); macOS pinned it 32 pt from the top.This PR:
PanelBackdropViewwithpanelBackdropColor(backgroundat 85%, already used by the auth, guide and timezone panels) over a.windowBackgroundwithin-window blur. Only settings and welcome use this view.minHeightof the window) so it scrolls only when taller than the windowdocs/features/desktop-web-parity-checklist.mdSettings stays top-anchored, as web's
SettingsModal(anchor="top") is.Verify
VERDICT: PASSfrombun run verify --strict(type-check, lint, knip).bun cli contracts:swift --checkandbun cli desktop:export --checkpass.Not run locally: this cloud session has no Swift toolchain or Xcode, so the build and UI tests only run in macOS CI. The
parity-screenshotslabel is added separately so the settings and welcome captures show the new backdrop.Generated by Claude Code