Repository navigation
fix(web): suppress welcome on meet paths and tighten PostHog funnel - #4722
Merged
Merged
Conversation
Keep the welcome modal off public /meet routes and meetingSetup entry so booking setup is not interrupted. Session-scope welcome intro analytics so remounts and reloads do not duplicate funnel events. Flag internal traffic and drop bot user agents in PostHog before_send. Add environment on sync oauth_callback captures. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
added
the
agent-automerge
Cursor
tyler-dane
marked this pull request as ready for review
October 22, 2026 03:29
tyler-dane
enabled auto-merge
October 22, 2026 03:29
Contributor
|
Boot bundle: 511.6 KB gzip (-0.0 KB vs main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Visitors coming from public
/meetpages (including the/?meetingSetup=1booking setup handoff) should not see the welcome modal or duplicate welcome funnel events during remounts in the same tab session. This change blocks the modal on those routes, session-scopeswelcome_modal_shown,signup_step_viewed{welcome_viewed}, and step 1welcome_step_viewed, flags internal/test traffic for PostHog cohorts, drops bot and headless user agents inbefore_send, and addsenvironmenton syncoauth_callback(distinct id remains the principal id when known).Verify
Focused:
bun test:core packages/core/src/analytics/posthog-audience.util.test.ts, welcome modal/analytics and PostHog audience web tests,bun test:sync:fast,bun type-check,bun lint,bun test:web(710 pass). Fullbun run verify --stricthit intermittent paralleltest:web/test:e2efailures in the Cloud VM; CI is the gate.VERDICT: PASS (focused suites and static checks; full verify flaky locally)