Repository navigation
feat(experiments): partition model experiment requests - #3445
Merged
Merged
Conversation
markijbema
marked this pull request as ready for review
May 25, 2026 07:36
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe latest commit removes the default partition entirely (both the DDL and the monitoring check), eliminating any risk of stranded rows accumulating silently. Out-of-window inserts now fail immediately and visibly. No issues found across all reviewed files. Files Reviewed (6 files)
Reviewed by claude-sonnet-4.6 · 191,163 tokens Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_experiment_requestledger introduced by feat(gateway): route and persist model experiments #3325 into a PostgreSQL monthly range-partitioned table so experiment attribution and future retention operations scale with preview traffic.(usage_id, created_at)primary key while preserving request attribution foreign keys, constraints, and reporting/feedback indexes.exa_usage_logpattern without creating fallback rows that need operational relocation.Verification
Visual Changes
N/A
Reviewer Notes
model_experiment_requestbecause the table is currently empty; there is no data-copy phase.PARTITION BYor child partitions in its snapshot; the migration follows the existingexa_usage_logphysical-DDL precedent.