Skip to content

docs(experiments): refresh model experiments rollout plan - #3454

Merged
markijbema merged 2 commits into
mainfrom
mark/experimental-models-plan-refresh-main
May 25, 2026
Merged

markijbema merged 2 commits into
mainfrom
mark/experimental-models-plan-refresh-main

Conversation

@markijbema

Copy link
Copy Markdown
Contributor

Summary

Verification

Visual Changes

N/A

Reviewer Notes

@markijbema
markijbema marked this pull request as ready for review May 25, 2026 11:25
@markijbema
markijbema enabled auto-merge (squash) May 25, 2026 11:25
@markijbema
markijbema merged commit 340cf4b into main May 25, 2026
13 checks passed
@markijbema
markijbema deleted the mark/experimental-models-plan-refresh-main branch May 25, 2026 11:26
@kilo-code-bot

kilo-code-bot Bot commented May 25, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Docs-only refresh of .plans/experimental-models-1.md accurately reflects merged implementation state with no logic errors or inconsistencies.

Files Reviewed (1 file)
  • .plans/experimental-models-1.md

Review notes:

  • Status table correctly updated from [merged-pending]/[in-progress] to [done]/[done-core]/[partial].
  • Removal of system_prompt_sha256 (dual-hash model → single request_body_sha256) is consistent throughout: schema definition, wipe semantics, test cases, and manual verification steps all updated in lockstep.
  • The decryption-point change (Redis-cached plaintext → per-request selected-variant-only decrypt) is a security improvement and is accurately described in the API Keys section, Risk Areas, and Caching/Privacy/Logging sections.
  • The removal of modelExperimentRedisKey (per-public-id Redis cache) is reflected consistently: Phase 3/5 output sections, cache invalidation description, and risk areas all updated.
  • The skipBalanceCheck removal in favor of isFreeModel is noted consistently in the pseudocode type definition and routing scope section.
  • The "Stale membership cache — follow-up" section has been replaced with a design-decision description. The new design accepts the failure mode (Redis recompute fails → experiment silently not routed) without a TTL fallback. This is an intentional documented trade-off, not an omission.
  • The should softening in the GDPR/soft-delete test bullet is appropriate given Phase 6 status is [partial] and the test is explicitly listed as still owed.

Fix these issues in Kilo Cloud


Reviewed by claude-sonnet-4.6 · 600,818 tokens

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants