Repository navigation
Conversation
498940a to
15828c6
Compare
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file, incremental delta)
Previous Review Summaries (2 snapshots, latest commit 64df058)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 64df058)Status: No Issues Found | Recommendation: Merge Files Reviewed (5 files, incremental delta)
Previous review (commit 15828c6)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (15 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
15828c6 to
64df058
Compare
64df058 to
68567d8
Compare
|
Superseded by #14093, which now targets main directly and carries a superset of this change. #14093 has the same docs-sync work — the surface map, per-surface PRs, the reviewer ranking, the max-effort model config, the bun.lock change and the orphan ghostty-web patch removal — plus two additions: the cloud repo's product surfaces (their docs live in this repo, so they were falling to the Three open PRs were implementing one feature. Collapsing to one. Any review finding raised here still applies and should be re-checked against #14093. |
Changelog for users
otherpull request, instead of a single rolling pull request.otherpull request uses lambertjosh and intentionally-left-nil.other, and how its reviewers were computed.workflow_dispatchdry run still collects and triages and opens no pull request.Changelog for maintainers
surfaces.jsonis the committed surface map (cli, vscode, jetbrains, gateway, web, plusother), and a path resolves to exactly one surface by longest prefix match;upsert-pr.mjsrebuilds each surface branch in a throwaway worktree so a doc file lands in exactly one pull request and human commits survive;prepare-branch.mjskeepsdocs/auto-syncas the integration base and pushes the tree to the sibling refdocs/auto-sync-integration;reviewers.mjsranks contributors with a 180-day half-life and drops bots and non-writers, replacingDOCS_OWNER;lib.mjsexportsREASONING_VARIANT, the workflow cites the Kilo gateway DeepSeek id with--variant maxat everykilo runcall site, andmodel-config.test.mjsplussurfaces.test.mjscover the wiring, with the selftest job running every.github/docs-sync/*.test.mjs..github/docs-sync/upsert-pr.mjs:460— accepted and fixed:git checkoutcannot apply a deletion, so the branch runsgit rm -rf --ignore-unmatchon the deleted paths first and then restores the rest from the integration tree; selftest case 16 covers a deletion and an added page landing on the same surface branch..github/docs-sync/reviewers.mjs:124— rejected, no change: a failed permission lookup is caught and degrades to the documented explanatory note, so it never assigns a wrong person..github/docs-sync/prepare-branch.mjs:211— rejected, no change: the stale remote-tracking ref must be removed for the surface branches to coexist withdocs/auto-sync, and the cleanup only warns when it fails..github/docs-sync/reviewers.mjs:109— rejected, no change: the commit mapping skips a commit with no linked GitHub account, which is the intended reviewer-candidate behavior..github/docs-sync/upsert-pr.mjs:580— accepted:learn.mjslearns corrections from every open surface pull request, not just the first, and patches each pull request's learned-through marker; case 17 covers it..github/docs-sync/upsert-pr.mjs:695— accepted: a skipped surface refreshes its open pull request's processed-through marker, and the watermark comes from the most recently updated pull request; cases 19-20 cover it..github/docs-sync/prepare-branch.mjs:203— accepted: the legacydocs/auto-syncbranch is deleted whenever it exists, not only when an open legacy pull request exists; case 18 covers it.E2E proof
No live proof applies: the change is offline GitHub Actions docs-sync scripting, and the repair touches only
learn.mjs,prepare-branch.mjs,selftest.mjs,upsert-pr.mjs, andwatermark.mjs, so there is no runtime surface to record. This replaces the earlier selftest proof claim: the superseded cases 12-15 statement gives way to the selftest cases 16-20, which cover the page deletion, per-pull-request learnings, legacy-ref cleanup, and skipped-surface marker refresh.Owner manual verification
The workflow skipped these checks. Owner verification is pending; these checks did not pass automatically.
Owner request