Repository navigation
feat(docs-sync): open per-surface docs PRs, rank reviewers, and cover the cloud product surfaces - #14093
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Both findings from the previous review are resolved at HEAD, and the incremental diff (
Files Reviewed (2 files)
Previous Review Summary (commit 989262c)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 989262c)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
SUGGESTION
Files Reviewed (11 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
iscekic
changed the base branch from
kwf/docs-sync-scope-and-proof-07b7
to
main
September 13, 2026 18:07
This was referenced Sep 13, 2026
iscekic
marked this pull request as draft
September 13, 2026 18:14
iscekic
added a commit
that referenced
this pull request
Sep 13, 2026
… the cloud product surfaces #14093
iscekic
force-pushed
the
kwf/docs-sync-cloud-surfaces-v2-de1e
branch
from
September 13, 2026 18:30
989262c to
7374ffa
Compare
… the cloud product surfaces #14093
iscekic
force-pushed
the
kwf/docs-sync-cloud-surfaces-v2-de1e
branch
from
September 13, 2026 18:33
7374ffa to
4e0e56a
Compare
iscekic
marked this pull request as ready for review
September 13, 2026 18:40
eshurakov
approved these changes
Sep 14, 2026
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
docs/auto-sync-<date>pull requests alone: it no longer comments on or closes them, reads them as learning targets, or rewrites their bodies.otherreviewers; the run does not fail.Changelog for maintainers
.github/docs-sync/learn.mjs:455— Accepted: the learnings query had no head filter, so a legacy dated PR could be read and have its body rewritten. The loop now skips any head that is not adocs/auto-sync/<surface>branch, and selftest case 26 covers it..github/docs-sync/learn.mjs:945— Accepted: one failed marker PATCH aborted the loop and left the later targets stale. Each target now logs a warning on failure and the remaining targets still publish, and selftest case 27 covers it.sourcesentries now accept{ "repo": "...", "prefix": "..." }; a bare string still means this repository, so the committed map needs no rewrite.DOCS_SYNC_CLOUD_TOKEN(contents: readonKilo-Org/cloud), read asCLOUD_REPO_TOKEN. An unreachable history or missing token returns the fixedotherpair (fallback: true), still opens the surface pull request, and exits 0.isSurfaceBranchandsurfaceNameFromBranchaccept onlydocs/auto-sync/<name>; the bare integration ref and dateddocs/auto-sync-<date>refs are rejected.docs/auto-syncref because a ref cannot be a path prefix of another.updated-desc.surfaces.mjsandreviewers.mjsfirst; the cloud token and fallback path and the skipped-surface marker refresh are the risky parts.Computed surface map:
E2E proof — log excerpts
Owner request