Repository navigation
Fix post-0.4.0 release issues - #6
Merged
Merged
Conversation
- core: JitterSimulator::transform before fit is an error instead of applying zero noise (which scored as perfect jitter stability). - model: README example passes Some(1) for the Option<usize> positive class index; from_file errors name the parameter, not only the CLI flag. - cli: add --version. - pypasteur: expose __version__ (listed in __all__ so maturin's `import *` re-export picks it up). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from testing the published 0.4.0 crates and
pypasteurwheel against the synthetic-cohort sandbox models.Fixes
JitterSimulator.transformbeforefitsilently did nothing.feature_stdstarted at0.0, so an unfitted simulator returned the data unchanged, which an evaluation would score as perfect jitter stability. It is nowOption<f64>andtransformerrors when it is unset. In Python this raisesValueError. The behaviour dates from 0.3.0. The CLI always fits first, so CLI results are unchanged.pasteur-modelREADME example didn't compile against 0.4.0. It passed1wherefrom_filenow takesOption<usize>. That README is the crates.io page.pasteur-cli --versionnow works.pypasteur.__version__is exposed. It is listed in__all__, because maturin's generated__init__.pyre-exports withimport *, which skips dunder names.Changelog entries are under Unreleased. The workspace version is unchanged.
Testing
cargo fmt --all --check,cargo clippy --workspace --locked -- -D warningsandcargo test --workspace --locked --exclude pypasteur-bindingsall pass, run in a glibc 2.41 container. New tests:jitter_transform_before_fit_is_an_errorandversion_flag_prints_crate_version.tests/smoke.pypasses; it now also checks__version__and that an unfitted transform raises. A 13-check script covering the README's claims also passes.🤖 Generated with Claude Code