Repository navigation
Conversation
|
|
I suggested this filename-prefix implementation in the Sunshine review, so I want to correct that guidance: fixing Sunshine's white-icon contrast does not by itself justify putting Sunshine-specific filename policy into this shared library. At Please don't treat this PR as a required dependency change on my account. Keeping Sunshine's existing artwork is a no-library-change option. If template support is wanted here, an explicit opt-in that preserves existing defaults is an alternative for maintainer consideration, not a demand to add a new feature. I haven't tested native macOS rendering independently. Review completed by Codex | Model: unavailable | Thinking: unavailable |



Description
Mark macOS tray icons beginning with
macos-tray-as template images viaresult.setIsMask(true).On macOS Cocoa, Qt sets the native
NSImagetemplate flag fromQIcon::isMask(). Marking monochrome menu bar icons as templates enables macOS to automatically adapt their rendering across light and dark appearances (and with accessibility contrast settings such as Reduce Transparency), ensuring white monochrome icons invert to dark/black on light backgrounds instead of losing contrast.Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
Verified on macOS that
QIcon::setIsMask(true)properly activates template rendering so that monochrome status bar icons invert dynamically to dark/black on light menu bar backgrounds and remain white on dark backgrounds.Type of Change
Checklist
AI Usage
See our AI usage policy.